Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Additional Buttons during the installation #6422 #6444

Closed
wants to merge 4 commits into from
Closed

UX: Additional Buttons during the installation #6422 #6444

wants to merge 4 commits into from

Conversation

joomla-agency
Copy link

Issue: #6422

Additional Next/Back Buttons in the bottom of the page, during the Joomla 3.4.x installation.

Issue: #6422

Additional Next/Back Buttons in the bottom of the page, during the
Joomla 3.4.x installation.
@ghost
Copy link

ghost commented Mar 15, 2015

+1
No error, no b/c issues, better usability.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6444.

@infograf768
Copy link
Member

Please test this first with an RTL language.

@joomla-agency
Copy link
Author

RTL (Persian) Screenshot
rtltest

@infograf768
Copy link
Member

the issue is that text-right has no RTL equivalent.
Therefore we get:

screen shot 2015-03-17 at 12 55 16

@infograf768
Copy link
Member

I would change instances of text-right to pull-right

@joomla-agency
Copy link
Author

@infograf768 i think, for a RTL Reader is the new right button position an excepted one.

@infograf768
Copy link
Member

If the purpose of the PR is to present the same buttons on top and bottom, then RTL or LTR should be treated equally. Until now we have always mirrored RTL button positions in all Joomla.
That's only my 2 cents.

@ghost
Copy link

ghost commented Mar 17, 2015

@infograf768 You're absolutly right. My bad.

@joomla-agency
Copy link
Author

Ok. I change the Pull Request.

@infograf768
Copy link
Member

@joomla-agency
Please do.

@joomla-agency
Copy link
Author

@infograf768 done! Can someone test this again for LTR / RTL Support and all views?

@joomla-agency
Copy link
Author

Two screenshots for LTR and RTL
ltr
rtl

@coolcat-creations
Copy link
Contributor

@roland-d @joomla-agency branch is broken - maybe there is a way to restore?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6444.

@roland-d
Copy link
Contributor

@designbengel @joomla-agency I never recovered a deleted branch but StackOverflow tells us this:

Yes, you should be able to do git reflog and find the SHA1 for the commit at the tip of your deleted branch, then just git checkout [sha]. And once you're at that commit, you can just git checkout -b [branchname] to recreate the branch from there.

http://stackoverflow.com/questions/3640764/can-i-recover-branch-after-its-deletion-in-git

@zero-24
Copy link
Contributor

zero-24 commented Oct 10, 2015

Closing as we have a redo here: #8052 by @n9iels

@zero-24 zero-24 closed this Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants