-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up the 'core' javascript file #6512
Conversation
@okonomiyaki3000 please check the |
28e4502
to
7659960
Compare
Uh. Great. These errors have nothing to do with any of these changes. Thanks, Travis. |
It seems that |
test works good for me |
Travis recently sometimes stalls because it takes to long to fetch the dependencies with composer. |
#TEST OK Nice to have a cleaner Javascript implementation. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6512. |
RTC Thanks 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6512. |
Thank you @okonomiyaki3000. I've fixed the conflicts and merged the PR. |
@Kubik-Rubik I think this merge cause this issue: http://issues.joomla.org/tracker/joomla-cms/7388 |
@javigomez Thank you, we have to check it. @okonomiyaki3000 @Fedik @anibalsanchez Could you also take a look? |
yes, need some time, and I will make a pull ... if no one will make it faster 😄 |
@Kubik-Rubik there it is #7391 |
@Fedik Wow, that was fast. Thank you, I will check it soon. @javigomez Could you please test this PR #7391 by Fedik? |
@Fedik @Kubik-Rubik Thanks! |
This is the follow up to this here: #6509
Define the Joomla 'core' function inside of a strict closure, fix all the ensuing problems.
Testing
These functions are used all over the place and, since the file was not in strict mode before, the mistakes in it were not apparent anyway. So the best way to test is to first try #6509 and see where it goes wrong. There is usually a comment above each function to tell where it is used. These are generally reliable.
There are certainly several functions which are no longer used at all and some which are specifically deprecated. There is some chance that a 3rd party is using them but there should be a plan for removing all the junk.