Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DB errors in users latest module #6666

Closed
wants to merge 2 commits into from
Closed

Handle DB errors in users latest module #6666

wants to merge 2 commits into from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Apr 5, 2015

updated to handle DB errors like #6612 ,#6632, #6665 and for #6591

Testing info
set the db offline
or
simulate a db error
change line 37 from

->from('#__users AS a');

to

->from('#__users AS z');

before patch you get
trycatch

after you get
the module is not displayed

updated to handle DB errors like #6612 ,#6632, #6665 and for #6591

Testing info
simulate a db error 
change line 37 from
```
->from('#__users AS a');
```
to
```
->from('#__users AS z');
```

before patch you get

after you get

or
set the db offline ...
@davdebcom
Copy link
Contributor

@test
Works, after patch you don't see a SQL error anymore.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6666.

@ghost
Copy link

ghost commented Apr 10, 2015

Not sure if this should get merged with regards to discussion on #6710

@anibalsanchez
Copy link
Contributor

@test OK, no frontend SQL error showing internal information

(though it would be nice to show a generic error... instead of eating the excepton)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6666.

@zero-24
Copy link
Contributor

zero-24 commented Jun 6, 2015

@alikon can you add the generic message also here? Like: https://github.com/joomla/joomla-cms/pull/6700/files

added the generic message as requested
@alikon
Copy link
Contributor Author

alikon commented Jun 7, 2015

@anibalsanchez , @zero-24 thx for reporting
the generic msg was added

@zero-24
Copy link
Contributor

zero-24 commented Jun 7, 2015

RTC Thanks 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6666.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Jun 7, 2015
@Bakual Bakual closed this in 5bbb0ed Jun 16, 2015
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants