Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <strong> tag when displaying extension installer message. #6870

Closed
wants to merge 1 commit into from

Conversation

OctavianC
Copy link
Contributor

Issue

During the installation of any extension, the installer script can display its own message, including HTML content (which most extensions do). Since 3.4.0 the contents of this message is forcefully bold. I believe that #5729 introduced this.

Steps to replicate it

Install any extension that provides a HTML message upon installation. You'll notice that the whole message is wrapped in <strong> tags.

Proposed fix

It's simple: remove the <strong> tags that are wrapping the message supplied by the installation script. I have left the <strong> tags that show up when displaying the XML <description> tag since most people don't use HTML in there so it shouldn't be a problem. The non-bootstrapped version (before the PR) did display the description in <th> tags and the message in <td> tags, so I'm following what was already in place.

Before

bold-forced

After

no-bold

@zero-24
Copy link
Contributor

zero-24 commented Apr 30, 2015

@OctavianC do you think we need also remove the <strong> on line 19 in the same file?

@zero-24 zero-24 added PR-staging Language Change This is for Translators and removed Language Change This is for Translators PR-staging labels Apr 30, 2015
@OctavianC
Copy link
Contributor Author

As I said in my original post, <th> was in place before the change was introduced, so the <description> tag was indeed bold. I think we should keep it this way for now.

@zero-24
Copy link
Contributor

zero-24 commented Apr 30, 2015

ok Thanks 😄

@zero-24
Copy link
Contributor

zero-24 commented May 7, 2015

@test successful. Thanks for fixing it. One more tester 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6870.

@gunjanpatel
Copy link
Contributor

Tested successfully. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6870.

@joomla-cms-bot joomla-cms-bot changed the title Remove <strong> tag when displaying extension installer message. Remove tag when displaying extension installer message. May 9, 2015
@joomla-cms-bot joomla-cms-bot changed the title Remove tag when displaying extension installer message. Remove <strong> tag when displaying extension installer message. May 9, 2015
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 9, 2015
@zero-24
Copy link
Contributor

zero-24 commented May 9, 2015

RTC 😄

@Kubik-Rubik
Copy link
Member

Thank you @OctavianC for the contribution.

@Kubik-Rubik Kubik-Rubik closed this May 9, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.2 milestone May 9, 2015
johanjanssens pushed a commit to joomlatools/joomla-fork that referenced this pull request Jun 19, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@OctavianC OctavianC deleted the fix-strong-message branch November 23, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants