New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove <strong> tag when displaying extension installer message. #6870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@OctavianC do you think we need also remove the |
zero-24
added
PR-staging
Language Change
This is for Translators
and removed
Language Change
This is for Translators
PR-staging
labels
Apr 30, 2015
As I said in my original post, |
ok Thanks 😄 |
@test successful. Thanks for fixing it. One more tester 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6870. |
Tested successfully. Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6870. |
joomla-cms-bot
changed the title
Remove <strong> tag when displaying extension installer message.
Remove tag when displaying extension installer message.
May 9, 2015
joomla-cms-bot
changed the title
Remove tag when displaying extension installer message.
Remove <strong> tag when displaying extension installer message.
May 9, 2015
RTC 😄 |
Kubik-Rubik
pushed a commit
that referenced
this pull request
May 9, 2015
Thank you @OctavianC for the contribution. |
johanjanssens
pushed a commit
to joomlatools/joomla-fork
that referenced
this pull request
Jun 19, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
During the installation of any extension, the installer script can display its own message, including HTML content (which most extensions do). Since
3.4.0
the contents of this message is forcefully bold. I believe that #5729 introduced this.Steps to replicate it
Install any extension that provides a HTML message upon installation. You'll notice that the whole message is wrapped in
<strong>
tags.Proposed fix
It's simple: remove the
<strong>
tags that are wrapping the message supplied by the installation script. I have left the<strong>
tags that show up when displaying the XML<description>
tag since most people don't use HTML in there so it shouldn't be a problem. The non-bootstrapped version (before the PR) did display the description in<th>
tags and the message in<td>
tags, so I'm following what was already in place.Before
After