Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #6855. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS. #6873

Closed
wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 30, 2015

See discussion here
#6855

Test:

  • Use template Protostar.
  • Create new module mod_search.
  • Enter 10 in field Box Width (size).
  • See front end: Size attribute of search input is ignored because Bootstrap CSS sets a fixed width that overrides size attribute.
  • Apply patch.
  • See front end: Search INPUT has width (size) 10 now.
  • Leave field Box Width empty in module settings.
  • CSS width rules now.

@ghost ghost changed the title Fixes #4879. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS. Fixes #6855. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS. Apr 30, 2015
@Webdongle
Copy link
Contributor

@test

Applied patch
Changed size of search box in the search module edit screen
Viewed from front end No Avail
No change in the size of the search box

Does Not work


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.

@ghost
Copy link
Author

ghost commented May 1, 2015

@Webdongle Cannot confirm.
Installed a fresh Joomla 3.4.1 right now and got these results:

Before patch

mod_search

After patch

mod_search2

Test with Firebug after patch

mod_search3

How did you apply the patch? Did you replace all files (3)?

Give com_patchtester a try: https://github.com/joomla-extensions/patchtester/releases

@infograf768
Copy link
Member

This works here.

@Webdongle
Copy link
Contributor

Tested again this time success ... the width of the box changed

SUCCESS

The search box in the components area of the results page does not alter but the search box in the module position works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.

@zero-24
Copy link
Contributor

zero-24 commented May 1, 2015

Great so RTC'ing here 😄


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873.

@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label May 1, 2015
@ghost
Copy link
Author

ghost commented May 1, 2015

@Webdongle

The search box in the components area of the results page does not alter

Component has no setting Box Width.
size=30 is hard coded there.

So, this argument does not convince me concerning component com_search
#6855 (comment)

Line 20:
$doc is not always defined. So, changed $doc to JFactory::getDocument()
@Webdongle
Copy link
Contributor

On 01/05/2015 15:43, bertmert wrote:

@Webdongle https://github.com/Webdongle

The search box in the components area of the results page does not
alter

Component has no setting /Box Width/.
size=30 is hard coded there.

So, this argument does not convince me concerning component com_search

@bertmert

It was not an argument to convince you of anything ... it was an
observation. Your quote of me was out of context. The full quote "/The
search box in the components area of the results page does not alter but
the search box in the module position works as expected/". There are two
clauses in that sentence with the word 'but' as a conjunction
http://www.bbc.co.uk/worldservice/learningenglish/grammar/learnit/learnitv161.shtml
. That implies the first clause has no direct affect on the second. So
please do not twist my words by quoting part of the sentence.

To be clear (just in case English is not you first language) ...
After my first test failed and others tested successfully ... I realised
that my test must have been inaccurate so I tested again. That test was
successful but I noticed the search box in the result page did not
change. To save time typing several sentences I used one sentence with
two clauses. I should have realised that my correct use of English
Grammar would have been misinterpreted. And I should have put my
observation of the results page in a separate paragraph explaining that
I am not as thick as you think am because I realise they are two
different things.

@ghost
Copy link
Author

ghost commented May 6, 2015

@Webdongle

To be clear (just in case you're not able to understand Github principles)

This PR has a title. It's referenced to an issue plus discussion, that also has a title. Read it.

If you have additional problems with **com_**search, that need a different way to solve it because com_search has no option Box Width, do not use issues concerning **mod_**search because you're comment will be ignored. If it would be a smiliar solution I would have created an additional PR because mbabker's comment would have convinced me.
Thus YOU have to open a new issue, provide a test instruction, define a feature request, describe your expected result, whatever ... instead of telling me bla bla... (Be aware that I won't read it because I'm not a native-speaking English teacher and will not understand it.)

@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants