-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #6855. mod_search. Option *Box Width* (size) ignored if INPUT width also set by CSS. #6873
Conversation
Applied patch Does Not work This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873. |
@Webdongle Cannot confirm. Before patch After patch Test with Firebug after patch How did you apply the patch? Did you replace all files (3)? Give com_patchtester a try: https://github.com/joomla-extensions/patchtester/releases |
This works here. |
Tested again this time success ... the width of the box changed SUCCESS The search box in the components area of the results page does not alter but the search box in the module position works as expected. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873. |
Great so RTC'ing here 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6873. |
Component has no setting Box Width. So, this argument does not convince me concerning component com_search |
Line 20: $doc is not always defined. So, changed $doc to JFactory::getDocument()
On 01/05/2015 15:43, bertmert wrote:
It was not an argument to convince you of anything ... it was an To be clear (just in case English is not you first language) ... |
To be clear (just in case you're not able to understand Github principles) This PR has a title. It's referenced to an issue plus discussion, that also has a title. Read it. If you have additional problems with **com_**search, that need a different way to solve it because com_search has no option Box Width, do not use issues concerning **mod_**search because you're comment will be ignored. If it would be a smiliar solution I would have created an additional PR because mbabker's comment would have convinced me. |
See discussion here
#6855
Test: