Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsfeeds - move Filters from left to [Search Tools] #6952

Closed
wants to merge 2 commits into from
Closed

Newsfeeds - move Filters from left to [Search Tools] #6952

wants to merge 2 commits into from

Conversation

pe7er
Copy link
Contributor

@pe7er pe7er commented May 15, 2015

This PR moves the Filter options of the Newsfeeds to the [Search Tools] button.
Note: The ordering dropdown in [Search Tools] needs to be fixed before merging.
(See Issue #6941 regarding the inconsistency with Filter options).

Test instructions

In back-end > Components > Newsfeeds
See the filters on the left

screen shot 2015-05-15 at 08 07 33

Compare with the filters in Category Manager for Newsfeeds:
In back-end > Components > Newsfeeds > Categories

screen shot 2015-05-15 at 08 07 33

This PR changes moves the Filters

from the left to the middle column and will be visible when you click on the [Search Tools] button.

screen shot 2015-05-15 at 08 07 33

Notes:

I can use some help & suggestions regarding the following issues:

  • The ordering dropdown in [Search Tools] is currently not working
  • The /administrator/components/com_newsfeeds/views/newsfeeds/tmpl/default.php might have old obsolete code in it
  • The /administrator/components/com_newsfeeds/views/newsfeeds/view.html.php still has protected function getSortFields() which might be obsolete because the order options are now specified in /administrator/components/com_newsfeeds/models/forms/filter_newsfeeds.xml

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label May 15, 2015
@brianteeman
Copy link
Contributor

After applying the patch the filters do move - great
BUT
After applying a filter they are hidden again - if you look at article manager they are still open


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

@brianteeman
Copy link
Contributor

Also as Tag information is NOT visible in the list view it seems strange to me for their to be a filter


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

@pe7er
Copy link
Contributor Author

pe7er commented May 26, 2015

Thanks for testing! I've to check the issue with the [Search Tools] closing after filtering.

I agree with removing the "Tag" filter as it's not displayed in any of the columns.

@coolwebcreations
Copy link

Works fine
BUT
the filters are hidden after applying


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

@pe7er
Copy link
Contributor Author

pe7er commented May 30, 2015

Thanks for testing. I corrected the problem with the closing Search Tools for Category + Tags filter.
Now the [Search Tools] should remain opened when any of the filters has been selected.

@brianteeman
Copy link
Contributor

Retested and all good now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

@brianteeman
Copy link
Contributor

Setting RTC now - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6952.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jun 5, 2015
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Jun 6, 2015
@mbabker
Copy link
Contributor

mbabker commented Jul 11, 2015

Merged to 3.5-dev via c8b9875

@mbabker mbabker closed this Jul 11, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@pe7er pe7er deleted the search-tools-filters-newsfeeds branch November 5, 2015 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants