Change PHP 7 Exception handling to catch Throwable #7198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bakual
pushed a commit
that referenced
this pull request
Jun 19, 2015
Change PHP 7 Exception handling to catch Throwable
|
Merged on review. |
johanjanssens
added a commit
to joomlatools/joomlatools-platform
that referenced
this pull request
Mar 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per PHP's Throwable RFC, a change has been made in PHP 7's error handling. Long and short, the
BaseExceptionclass is gone and the two error branches (ExceptionandError(previouslyEngineException)) now implement theThrowableinterface. This PR updates our adoption of the previous exception objects to follow the newly implemented interfaces.Note that this change is now implemented in the PHP 7 branch. Travis-CI (as of the time this was opened) may not yet be updated with this change.