Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Messages modal converted to bootstrap #7624

Closed
wants to merge 13 commits into from
Closed

Backport Messages modal converted to bootstrap #7624

wants to merge 13 commits into from

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 3, 2015

see: https://github.com/joomla-extensions/messages/pull/7 and #4563 we initial move that code to the messages repo but is should be also in the main repo.

All the work is done by @dgt41 and this change is allready tested see: http://issues.joomla.org/tracker/joomla-cms/4563

(Restored initial PR comment on #4563)


Move modals from mootools to Bootstrap

Testing:
NOW this IS the last PR to get all back end using bootstrap modals. The rest are: #4513 #4514 #4561 and #4562

Try the my settings button on Components->Messaging
On administrator/index.php?option=com_messages the settings button on the toolbar uses modal

screenshot 2014-10-12 09 07 49

screenshot 2014-10-12 09 08 03

@zero-24 zero-24 added this to the Joomla! 3.4.4 milestone Aug 3, 2015
@zero-24 zero-24 changed the title Backport Messages modal converted to bootstrap Backport Messages modal converted to bootstrap Aug 3, 2015
@zero-24
Copy link
Contributor Author

zero-24 commented Aug 4, 2015

Woops wrong base branch. I will reopen it later.

@zero-24 zero-24 closed this Aug 4, 2015
@zero-24 zero-24 deleted the backport_messages branch August 4, 2015 06:27
@zero-24 zero-24 removed this from the Joomla! 3.4.4 milestone Sep 5, 2015
@dgrammatiko
Copy link
Contributor

@zero-24 can you redo this one, it's still valid and probably needed 😉

@zero-24 zero-24 restored the backport_messages branch October 20, 2015 03:59
@zero-24 zero-24 reopened this Oct 20, 2015
@zero-24 zero-24 closed this Oct 20, 2015
@zero-24
Copy link
Contributor Author

zero-24 commented Oct 20, 2015

Did i never redon it? I hope i get time this week.

@zero-24 zero-24 deleted the backport_messages branch November 2, 2015 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants