-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport Messages modal converted to bootstrap #7624
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero-24
changed the title
Backport Messages modal converted to bootstrap
Backport Messages modal converted to bootstrap
Aug 3, 2015
Woops wrong base branch. I will reopen it later. |
@zero-24 can you redo this one, it's still valid and probably needed 😉 |
Did i never redon it? I hope i get time this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://github.com/joomla-extensions/messages/pull/7 and #4563 we initial move that code to the messages repo but is should be also in the main repo.
All the work is done by @dgt41 and this change is allready tested see: http://issues.joomla.org/tracker/joomla-cms/4563
(Restored initial PR comment on #4563)
Move modals from mootools to Bootstrap
Testing:
NOW this IS the last PR to get all back end using bootstrap modals. The rest are: #4513 #4514 #4561 and #4562
Try the my settings button on Components->Messaging
On administrator/index.php?option=com_messages the settings button on the toolbar uses modal