Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Module (Front end) Loses Module Position if Position not defined in Template XML #7964

Closed
xmanflash opened this issue Sep 28, 2015 · 9 comments

Comments

@xmanflash
Copy link

xmanflash commented Sep 28, 2015

Steps to reproduce the issue

Assign a module to a custom position in the Joomla Administration, one that is not specified in the Template XML file.

Edit this module int eh Front end, and the custom Position isa not listed, causing the module to be aasigned to the first Position in the Position dropdown.

Expected result

The Custom Position should be retained. This will cause many customers issues.

The workaround is to make sure we update the Template XML file with the custom positions, but this is not needed when editing in the Back End.

Cheers,
Pete

Actual result

System information (as much as possible)

Additional comments

@alexonbalangue
Copy link

the config after [...]/tpl/[name]/html is config or create style Jinclude.on file module.php

@roland-d
Copy link
Contributor

roland-d commented Aug 3, 2016

I am closing this issue as it no longer seems to be present in the current codebase as the front-end module editing only allows to choose a position from the current template. Thank you for your contribution.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7964.

@roland-d roland-d closed this as completed Aug 3, 2016
@brianteeman
Copy link
Contributor

That's the problem @roland-d

If you try to edit a module that is not in the list of modules in the templatedetails.xml then you can no longer save it in that custom position

@xmanflash
Copy link
Author

Roland - I don't think you understood the issue.

Module positions should not be limited to ones defined in the XML file
in the front end editor, if you can still randomly create them and use
them from the /administration/ section without needing to be in the xml
file.

Cheers,
Pete

On 03-Aug-16 8:16 PM, RolandD wrote:

I am closing this issue as it no longer seems to be present in the
current codebase as the front-end module editing only allows to choose
a position from the current template. Thank you for your contribution.


_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/7964
https://issues.joomla.org/tracker/joomla-cms/7964.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7964 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMSpOwoSR838-3yMbpgCpMaT9NHp7WY-ks5qcGqYgaJpZM4GErE4.

@mbabker
Copy link
Contributor

mbabker commented Aug 3, 2016

Reopening. As long as we support defining custom positions in the backend, saving the same record on the frontend should NOT cause data loss.

@mbabker mbabker reopened this Aug 3, 2016
@brianteeman
Copy link
Contributor

brianteeman commented Aug 3, 2016 via email

@roland-d
Copy link
Contributor

roland-d commented Aug 3, 2016

Sorry guys, in that case I did misunderstand the issue.

@brianteeman
Copy link
Contributor

@xmanflash looks like it is resolved by #7540 please test

@brianteeman
Copy link
Contributor

I am closing this as it is fixed by #7540


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants