Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contact list layout option filter field #8015

Merged
merged 1 commit into from Oct 6, 2015
Merged

contact list layout option filter field #8015

merged 1 commit into from Oct 6, 2015

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 5, 2015

following the report #8013 by @infograf768 other components have this issue like com_contact

Before

the Fiter field hide button should be red
jmongo administration contacts options-before

After

the Fiter field hide button is red
jmongo administration contacts options-after

@soap
Copy link
Contributor

soap commented Oct 5, 2015

I have tested this item ✅ successfully on 810451e
It works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8015.

@infograf768
Copy link
Member

We also may need this for com_content

@alikon
Copy link
Contributor Author

alikon commented Oct 5, 2015

@infograf768 looking at but seems ok 😛....

@YouriiM26
Copy link

I have tested this item ✅ successfully on 810451e
Works corectly.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8015.

@zero-24
Copy link
Contributor

zero-24 commented Oct 6, 2015

RTC Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8015.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 6, 2015
@zero-24 zero-24 added this to the Joomla! 3.4.5 milestone Oct 6, 2015
rdeutz added a commit that referenced this pull request Oct 6, 2015
contact list layout option filter field
@rdeutz rdeutz merged commit 3cd0359 into joomla:staging Oct 6, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 6, 2015
@infograf768
Copy link
Member

@alikon
Correct for com_content as this is not indeed a yes-no situation

com_weblinks though could appreciate the evolution. :)

@alikon
Copy link
Contributor Author

alikon commented Oct 6, 2015

should be like com_content cause the weblinks option Filter Field is type="list"

@alikon alikon deleted the contact branch October 6, 2015 19:17
@zero-24 zero-24 mentioned this pull request Oct 10, 2015
@infograf768
Copy link
Member

should be like com_content cause the weblinks option Filter Field is type="list"

WE should normalise it though to yes-no instead of list as there are only 2 choices 😄

@zero-24 zero-24 modified the milestones: Joomla! 3.4.6, Joomla! 3.5.0 Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants