New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging - remove duplicate submenu item #8057
Conversation
For some strange reason, I can not apply this patch via the Joomla! Patch tester. Is this a problem in my test installation? Or are there people with the same problem? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057. |
Quick comment without testing as I'm on a phone. The 'add new' is usually governed by a setting in the admin menu module
|
Did you reinstall Joomla after applying the patch? The submenus of the components under the Components menu are retrieved from the database. And the database settings are created upon installation. Therefore you'll need to reinstall Joomla with the patched SQL files. |
I can't not apply the patch. I have re-installed the newest joomla-cms-staging on my localhost. This is the error what I get when I apply the patch: Hopefully can you fix this issue. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057. |
That's by design with the patch tester. What that means is that it has found a backup of that file in the |
I have looked in the administrator/components/com_patchtester folder and this folder is empty. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057. |
I think the test description is not complete. The patch changes a file in the installation directory. I added the first list item.
|
I have tested this item ✅ successfully on 1a41dfb This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057. |
I have tested this item ✅ successfully on 1a41dfb Remember to update the IDs and also the lft, rgt values for the other entries in that table for the final version of this PR. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057. |
RTC @committer please take care on the comment by @matrikular This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8057. |
@zero-24 Do you mean me? |
@zero-24 The lft and rgt values do not need to be updated because the entries @pe7er is removing are not in the assets table. Only the main extension com_messages is in there but not the suboptions. The suboptions are only links to the component. As for updating the ID's, I wouldn't go through the hassle. It would be a major hassle to reclaim number 12. |
Messaging - remove duplicate submenu item
This PR removes the duplicate menu item in the Messaging submenu.
IMHO offering less (duplicate) options is better for UX.
Testing instructions
Before this PR
Components > Messaging (shows list of private messages) has two submenus:
Other components, like com_content, do not have such duplicate options.
See Content > Articles (shows list of articles) > has one submenu item Add New Article (create new article form)
After this PR
The administrator menu items are created from records in the database.
The database settings are created upon installation and therefore the testing procedure is a bit different:
Components > Messaging now has only one submenu: New Private Message
Note: I have only removed the duplicate menu item in the MySQL files (Joomla core installation and all different sample data files), and in tests/system/webdriver/Pages/System/AdminPage.php and tests/unit/stubs/database/jos_menu.csv.
I have not yet changed it in Postgresql, nor in SQLAzure. I would like to have this PR tested before I'll make the necessary changes in those two databases.