Fix for #8034 - smart search fail on $

[Fedik]

this fix for #8034
the problem was that $ is striped and the highlighter script tries to highlight the emptiness, that cause high resource usage by highlight.js

for testing please look the description in related issue 😉

---

Steps to reproduce the issue

• enable smart search & smart search module
• index content so it's not empty
• search for "$" (single dollar sign)

Expected result

some search results

Actual result

javascript loop resulting in massive memory leak and eventual browser crash

System information (as much as possible)

browser = firefox
OS = Win 10

Additional comments

[alikon]

tested succesfully now no more loop and browser crash
not sure if is it out of scope of this pr but
something is still wrong :

wrong text $ sign is missed

wrong search result the $$$ is not matched/highlight

[Fedik]

the problem was that $ is striped and the highlighter tried highlight emptiness, that cause high resource usage by highlight.js

[alikon]

i'm a js 🐤, just noticed that for search works as expected

surely @dgt41 can help us

[Fedik]

$ is striped not in javascript, but somewhere in Smart Search component while handle the input ... I have not searched 😄

[chrisdavenport]

I haven't checked the code, but I would think that all "punctuation" characters will be stripped. Same for the indexer. That would be expected behaviour.

[alikon]

@chrisdavenport Not so sure we can consider $ , € etc ..... a punctuation character
or at least not in all languages
so i think com_search is doing the correct behavior
what i'm missing?

[chrisdavenport]

For the kind of websites I normally work with I wouldn't want these characters cluttering up the index. However, I can imagine that there would be occasions where some websites might want to retain them. I would suggest that this needs to be configurable because it depends on the particular application. It's rather like how we currently have a list of "stop words" that are not indexed. I think we should have a configurable list of "stop characters" that are discarded and/or regarded as delimiters. I'd be happy to review a PR for that feature.

[alikon]

👍

p.s.
i'm sorry for my shortsight, i usually work with ($, €) characters 👽
damned banking software work

[chrisdavenport]

I have tested this item ✅ successfully on f3f7e62

The specific issue reported by @Fedik is fixed by this PR.

The consequential issue reported by @alikon should be the subject of a separate PR along the lines I suggested.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8097.}

[zero-24]

I have tested this item ✅ successfully on f3f7e62

This specific issue is fixed. Thanks.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8097.}

[zero-24]

RTC. Thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8097.}

[Kubik-Rubik]

Thank you @Fedik and testers!