Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add autocomplete=email to form filds (Ref #6998) #8149

Merged
merged 1 commit into from Nov 16, 2015

Conversation

sudo-web
Copy link
Contributor

Additional support, to help user by autocompleting there email address in requested forms.
Fully supports the "autocomplete" attribute for form fields according to the current WHATWG HTML Standard.
Informational link to that topic:
http://googlewebmastercentral.blogspot.ru/2015/03/helping-users-fill-out-online-forms.html
Added attribute to email address field on the following forms:
com_contact : contact
com_user : registration, profile , remind

@sudo-web
Copy link
Contributor Author

Hey folks,
How do I get a (this) pull request merged to an existing issue?
In this case to #6998


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@zero-24
Copy link
Member

zero-24 commented Oct 26, 2015

Just done @sudo-web ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@sudo-web
Copy link
Contributor Author

@zero-24 do I see it right, a merge or to create a pull request that is already linked to an existing issue could not done by myself?
I didn’t find any documentation to that question, that not includes the hub command and I'm not sure if that works in our case


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@zero-24
Copy link
Member

zero-24 commented Oct 26, 2015

@sudo-web you don't need to merge something ;) If you fix a issue you just need to add a link on that issue to your pull request. Than a Maintainer can close the issue with referece to your pull 😄

@waader
Copy link
Contributor

waader commented Nov 5, 2015

I have tested this item ✅ successfully on 8d5f65a

Thanks sudo-web!

Is there a reason why you have omitted reset_request.xml or email2 in profile.xml and registration.xml?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@sudo-web
Copy link
Contributor Author

sudo-web commented Nov 5, 2015

It is security vs comfort.
I thought, that this are the cases where I really want the user to fill in the fields.
So the first email goes with autocomplete but the second has to be filled in by the user.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@waader
Copy link
Contributor

waader commented Nov 5, 2015

I thought something along those lines.

@anibalsanchez
Copy link
Contributor

Test OK - autocomplete="email" is added in modified forms.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 8d5f65a

Test OK - autocomplete="email" is added in modified forms.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Nov 6, 2015
@zero-24
Copy link
Member

zero-24 commented Nov 6, 2015

RTC thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8149.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 6, 2015
rdeutz added a commit that referenced this pull request Nov 16, 2015
add autocomplete=email to form filds (Ref #6998)
@rdeutz rdeutz merged commit 8f93623 into joomla:staging Nov 16, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants