Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin SEF - Allow to turn off not used checks, for improve performance. #8233

Closed
wants to merge 3 commits into from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Nov 1, 2015

Suggested pull allow to turn off checks for not used types,
this can improve page rendering speed on huge site.

test
apply patch and make sure that all still work as before

ps. I need help with better strings for labels and descriptions, can someone suggest better?

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Nov 1, 2015
@andrepereiradasilva
Copy link
Contributor

I understand what you are tring to do here. complex preg_replace is very expensive.
How much ms did you manage to save with this code?

Netherless, i don't know if adding more options ... is the best way to achieve the goal.

Isn't there any way to optimize the regexs or for instance do a strpos before making the regex? Many pages don't have object or onclick or whatever... maybe some ms can be saved with this.

check this for instance http://stackoverflow.com/questions/29726949/is-using-strpos-before-preg-replace-faster

@Fedik Fedik closed this Feb 15, 2016
@Fedik Fedik deleted the plugin-sef-imr branch February 15, 2016 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants