Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about content plugins to view layouts #8517

Merged
merged 2 commits into from Nov 27, 2015

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Nov 21, 2015

Issue

Currently it's not that intuitive to find out where those next/prev and other plugin generated output is coming from.

Solution

This PR just adds some simple PHP comments into the layouts which state the triggered event responsible for the generated output.
This should make it easier for frontend devs to figure out where to look.

Testing

Not much you can test here since it only adds PHP comments into the layout. Make sure all com_contact and com_content views are still the same before and after.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 4040f6a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8517.

@zero-24
Copy link
Contributor

zero-24 commented Nov 25, 2015

Maybe this can be implemented only if debug is enabled and not just for com_content? Maybe in the event itself? Or any other generic place? I'm not sure if we hafe a functin thats get called on every plugin event ?

@Bakual
Copy link
Contributor Author

Bakual commented Nov 25, 2015

Maybe this can be implemented only if debug is enabled and not just for com_content?

It's a PHP comment, not a HTML comment. So no output at all. 😄
It is meant to indicate in the view layout itself where the content from that property is coming from.

@alikon
Copy link
Contributor

alikon commented Nov 25, 2015

tested successfully
it adds more code readabilty so always welcome for me

@zero-24
Copy link
Contributor

zero-24 commented Nov 25, 2015

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8517.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 25, 2015
@pjwiseman
Copy link
Contributor

I have tested this item ✅ successfully on 4040f6a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8517.

@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Nov 26, 2015
rdeutz added a commit that referenced this pull request Nov 27, 2015
Add comment about content plugins to view layouts
@rdeutz rdeutz merged commit 6e1ebfa into joomla:staging Nov 27, 2015
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 27, 2015
@Bakual Bakual deleted the AddComment branch November 27, 2015 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants