Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

article layout override from category #8579

Closed
wants to merge 4 commits into from
Closed

article layout override from category #8579

wants to merge 4 commits into from

Conversation

shamsbd71
Copy link

@shamsbd71 shamsbd71 commented Dec 1, 2015

Joomla has the ability to set the articles details page layout from category menu item. but it wasn't implemented. just add these xml and its gonna work perfect.

Before

image

After

image

Joomla has the ability to set the articles details page layout from category menu item. but it wasn't implemented. just add these xml and its gonna work perfect.
@ghazal
Copy link
Contributor

ghazal commented Dec 3, 2015

Test OK.
I hadn't figured out it was missing. But actually, it is.
TKS.

@mikeveeckmans
Copy link

I have tested this item ✅ successfully on 96822b7

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@coolcat-creations
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 96822b7

I added a cuatom template override and it doesn´t appear in the list.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@coolcat-creations
Copy link
Contributor

Btw: We tested also when adding an override for an article, and that worked. But that seems not logical to me, because i expect to be able to choose a category list override there?
Maybe we need then two fields there 1) List view layout and 2) Article view layout


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@webnet-assmann
Copy link

I have tested this item ✅ successfully on 96822b7

Alternative Layout is working for Articles. It's a bit confusing. It should be called Alternative Layout for Articles.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@webnet-assmann
Copy link

Alternative Layout is working for Article. It's a bit confusing. It should be called Alternative Layout for Articles.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @designbengel, @mikeveeckmans, @webnet-assmann


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@shamsbd71
Copy link
Author

Yes i agree that if we change the label to Alternative Layout for Articles would be more clear.
Need to add the language then. I'll add the correct language.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @designbengel, @mikeveeckmans, @webnet-assmann


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @designbengel, @mikeveeckmans, @webnet-assmann


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Apr 10, 2016
@conconnl
Copy link
Member

@shamsbd71 are all the comments integrated in the patch?
If so, I and hopefully others can test this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@shamsbd71
Copy link
Author

@conconnl yes it is.
thanks

@schmidtpaddy
Copy link

I have tested this item 🔴 unsuccessfully on cdf7dc4

field alternative layout didn't appear @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@shamsbd71
Copy link
Author

@schmidtpaddy there are two files, please try both. you have applied only language file changes.
https://github.com/joomla/joomla-cms/pull/8579/files
thanks

@Schmidie64
Copy link
Contributor

tested:

  • install plugin successfully
  • everything worked well
    @icampus

@Schmidie64
Copy link
Contributor

I have tested this item ✅ successfully on cdf7dc4

tested:
•install plugin successfully
•everything worked well @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@roland-d
Copy link
Contributor

roland-d commented Aug 2, 2016

@schmidtpaddy Can you test this once more please? Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@Sieger66
Copy link
Contributor

Sieger66 commented Aug 15, 2016

Alternative Layout for Article is Display and is a good feature but
I have testet #8579 the "Alternative Layout for Article" and see this problem (with and without SEO):

For example go to article-category-list-menuitem A -> Details -> Template Style and change to an other Template with Template-Override
( with a not default name of the override(unique name) ; for example: /html/com_content/article/my-66-override.php )

then go to List Layouts -> Alternative Layout for Article and see the not correct list in.
Then click the "Save"-Button and go Back to List Layouts -> Alternative Layout for Article and see the correct list now.

Now select this override "my-66-override" and save it.
Now the PR works as expected but if you now go to
article-category-list-menuitem A -> Details -> Template Style and change to an other Template and save it.

Then works the override furthermore.

If you now go to the article-category-list-menuitem to List Layouts -> Alternative Layout for Article and change this to "From Component -> default" and save it then is come the expected result(view without the override from the other Template).

Similar problem as in my post in #8578

I hope this is helpful.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579.

@shamsbd71
Copy link
Author

@Sieger66

You make two article-category-list-menuitems A B
both for the same article-category

This is wrong! you should not create the same menu twice and it's not practical either.

If you check Joomla routing, you are creating confusion for the routing not for the menu item.

This setting works based on menu item id. so when you have duplicate menu itemid for the same category, you are confusing yourself :(

thanks

@Sieger66
Copy link
Contributor

Sieger66 commented Aug 16, 2016

But the Problem in my first post in this PR is a problem that comes with this PR.

To solve this it is additional or changed code required.

@microtribe
Copy link

I have tested this item ✅ successfully on cdf7dc4

I tested this - first to confirm that the Alternative Layout selector was not available. Then I used the Patch Tester to install the patch. Then created a Category List menu item. Then check to see if the Alternative Layout selector was visible - it was. Then I created an article alternative layout override. Then I visited the Category List menu item, and the Alternative Layout I created was also visible and selectable.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8579.

@ghost
Copy link

ghost commented Jan 6, 2017

I have tested this item 🔴 unsuccessfully on cdf7dc4

All works like @microtribe wrote above, but "Show Votes in List" and "Show Ratings in List" isn't shown anymore after Patch.

Before Patch

before

After Patch

after


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8579.

@mbabker
Copy link
Contributor

mbabker commented May 21, 2017

This PR needs to be synchronized with the current development branches and the issues addressed for it to be reviewed.

@ghost
Copy link

ghost commented May 27, 2017

If this PR get no Response, it will be closed at 22th June 2017.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8579.

@coolcat-creations
Copy link
Contributor

How to sync it? should i create a new PR on the latest staging and reference it?

@brianteeman
Copy link
Contributor

@coolcat-creations yes that will be the easiest in this case

@brianteeman
Copy link
Contributor

closed please see #16755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet