New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
article layout override from category #8579
Conversation
Joomla has the ability to set the articles details page layout from category menu item. but it wasn't implemented. just add these xml and its gonna work perfect.
Test OK. |
I have tested this item ✅ successfully on 96822b7 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
I have tested this item 🔴 unsuccessfully on 96822b7 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
Btw: We tested also when adding an override for an article, and that worked. But that seems not logical to me, because i expect to be able to choose a category list override there? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
I have tested this item ✅ successfully on 96822b7 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
Alternative Layout is working for Article. It's a bit confusing. It should be called Alternative Layout for Articles. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
This PR has received new commits. CC: @designbengel, @mikeveeckmans, @webnet-assmann This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
Yes i agree that if we change the label to Alternative Layout for Articles would be more clear. |
This PR has received new commits. CC: @designbengel, @mikeveeckmans, @webnet-assmann This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
This PR has received new commits. CC: @designbengel, @mikeveeckmans, @webnet-assmann This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
@shamsbd71 are all the comments integrated in the patch? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
@conconnl yes it is. |
I have tested this item 🔴 unsuccessfully on cdf7dc4 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
@schmidtpaddy there are two files, please try both. you have applied only language file changes. |
tested:
|
I have tested this item ✅ successfully on cdf7dc4 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
@schmidtpaddy Can you test this once more please? Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
Alternative Layout for Article is Display and is a good feature but For example go to article-category-list-menuitem A -> Details -> Template Style and change to an other Template with Template-Override then go to List Layouts -> Alternative Layout for Article and see the not correct list in. Now select this override "my-66-override" and save it. Then works the override furthermore. If you now go to the article-category-list-menuitem to List Layouts -> Alternative Layout for Article and change this to "From Component -> default" and save it then is come the expected result(view without the override from the other Template). Similar problem as in my post in #8578 I hope this is helpful. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8579. |
This is wrong! you should not create the same menu twice and it's not practical either. If you check Joomla routing, you are creating confusion for the routing not for the menu item. This setting works based on menu item id. so when you have duplicate menu itemid for the same category, you are confusing yourself :( thanks |
But the Problem in my first post in this PR is a problem that comes with this PR. To solve this it is additional or changed code required. |
I have tested this item ✅ successfully on cdf7dc4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8579. |
I have tested this item 🔴 unsuccessfully on cdf7dc4 Before PatchAfter PatchThis comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8579. |
This PR needs to be synchronized with the current development branches and the issues addressed for it to be reviewed. |
If this PR get no Response, it will be closed at 22th June 2017. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8579. |
How to sync it? should i create a new PR on the latest staging and reference it? |
@coolcat-creations yes that will be the easiest in this case |
closed please see #16755 |
Joomla has the ability to set the articles details page layout from category menu item. but it wasn't implemented. just add these xml and its gonna work perfect.
Before
After