Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #8683 Relative URLs are not converted to absolute URLs in atom feed #8726

Merged
merged 1 commit into from Jan 6, 2016

Conversation

schubtob
Copy link

Issue #8683

This PR fixes a problem with relative URLs in atom feeds.
Prior to this commit relative URLs were only converted to absolute URLs in the summary tag and not in the content tag.

With the proposed change, relative URLs are also converted to absolute URLs in the content tag.

How to test

  1. Create an article including relative URLs and/or embedded images.
  2. Access the atom feed URL that includes this article.
  3. Notice that the relative URLs are converted to absolute URLs only in the summary tag and not in the content tag.
  4. Apply this PR
  5. Access the atom feed again and notice that relative URLs are converted in both the summary and the content tag.

Added conversion of relative URLs to absolute URLs for content tag of atom feed.
This unbreaks the resolving of URLs in feed readers.
@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 755372b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8726.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on 755372b

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8726.

@brianteeman
Copy link
Contributor

Setting RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8726.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 28, 2015
@rdeutz rdeutz added this to the Joomla! 3.5.0 milestone Jan 6, 2016
rdeutz added a commit that referenced this pull request Jan 6, 2016
Fix #8683 Relative URLs are not converted to absolute URLs in atom feed
@rdeutz rdeutz merged commit e6818c2 into joomla:staging Jan 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants