Replace leftover joomla.org (and subdomains) HTTP links for HTTPS links (where possible) #8791

andrepereiradasilva · 2015-12-26T18:38:00Z

Description

An year after #5478, this PR is for normalize the joomla.org URI in Joomla code to use HTTPS.

In this PR all joomla.org domains (and subdomains) in joomla code were checked, and then checked if those serve in HTTP, HTTP and HTTPS or exclusively HTTPS (HTTP redirect to HTTPS).

For the ones that the change seems possible without issues (certificate errors, protocols errors, redirects to HTTP, mixed content, etc) the change is done in this PR.

Please note this is not a blind search -> replace.

List of joomla.org domains (found in code and completly https with this PR)

Domain	Protocols	Observations	All URI in HTTPS?
joomla.org	HTTP and HTTPS	Forces HTTPS. Redirect to www.joomla.org	✅ (after this PR)
www.joomla.org	HTTP and HTTPS	Forces HTTPS	✅ (after this PR)
docs.joomla.org	HTTP and HTTPS	Forces HTTPS	✅ (after this PR)
developer.joomla.org	HTTP and HTTPS	Forces HTTPS	✅ (after this PR)
volunteers.joomla.org	HTTP and HTTPS	Forces HTTPS	✅ (after this PR)
events.joomla.org	HTTP and HTTPS	Forces HTTPS	✅ (after this PR)
issues.joomla.org	HTTP and HTTPS	Forces HTTPS	✅ (after this PR)
api.joomla.org	HTTP and HTTPS	Forces HTTPS	✅
demo.joomla.org	HTTP and HTTPS	Forces HTTPS	✅
contribute.joomla.org	HTTP and HTTPS	Forces HTTPS. Redirect to opensourcematters.org	✅ (after this PR)
help.joomla.org	HTTP and HTTPS	Forces HTTPS in both (/ and /proxy/)	✅ (after this PR)
cdn.joomla.org	HTTP and HTTPS	-	✅ (after this PR)

List of joomla.org domains (found in code but will have to wait for a future PR)

Domain	Protocols	Observations	All URI in HTTPS?
update.joomla.org	HTTP and HTTPS	-	PR related to this: #8645
shop.joomla.org	HTTP and HTTPS	HTTPS has Mixed content.	PR related to this: #8653
community.joomla.org	HTTP and HTTPS	HTTPS has Mixed content.	Site not ready yet.
resources.joomla.org	HTTP and HTTPS	HTTPS has Mixed content.	Site not ready yet.
extensions.joomla.org	HTTP and HTTPS	HTTPS redirect to HTTP	Site not ready yet.
forum.joomla.org	HTTP and HTTPS	HTTPS has protocol error.	Site not ready yet.
opensourcematters.org	HTTP	-	Site not ready yet.
feeds.joomla.org	HTTP	Feedburner	Not ready yet.
build.joomla.org	HTTP and HTTPS	Jenkings. Certificate error	Not ready yet.
joom.la	HTTP and HTTPS	Certificate error	Not ready yet.

Other domain in code

There are other domains used only for Unit tests to simulate errors but doesn't really exist or are only used in unit tests, so those were not changed:

base.joomla.org
test.joomla.org
xommunity.joomla.org

How to test

Check the "Files changed" in this PR and verify the changes.

More info

For checking the domains that exist in Joomla code it was used several egrep linux commands:

egrep -R 'joomla\.org' /path/to/joomla/
egrep -R 'http:(//|\\/\\/|\\\\/\\\\/)subdomain\.joomla\.org' /path/to/joomla/
egrep -R 'https:(//|\\/\\/|\\\\/\\\\/)subdomain\.joomla\.org' /path/to/joomla/
and other combinations

See joomla/joomla-websites#20 for a list of Joomla domains and the HTTP to HTTPS site conversion process.

Suggestions or corrections are welcome.

…la-cms into staging

…https-links

wojsmol · 2015-12-26T19:16:02Z

@andrepereiradasilva regarding cdn see first post of joomla/joomla-websites#20

mbabker · 2015-12-26T19:34:13Z

For help.joomla.org the help screen proxy (/proxy on that subdomain)
already defaults to HTTPS and the rest of the site is effectively offline
but the htaccess should be forcing HTTPS on the landing page last I
remember. So that's fine to change any leftover links. Though those links
should probably change to something suitable in the docs wiki.

On Saturday, December 26, 2015, andrepereiradasilva <
notifications@github.com> wrote:

Description

An year after #5478 #5478,
this PR is for normalize the joomla.org URI in Joomla code to use https.

In this PR all joomla.org domains (and subdomains) in joomla code were
checked, and then checked if those serve in HTTP, HTTP and HTTPD or
exclusively HTTPS (HTTP redirect to HTTPS).

For the ones that the change seems possible without issues (certificate
errors, protocols errors, redirects to HTTP, mixed content, etc) the change
is done in this PR.

Please note this is not a blind search -> replace.
List of joomla.org domains Domain Protocols Observations All URI in HTTPS?
joomla.org HTTP and HTTPS Both redirect to www.joomla.org [image:
✅](after this PR) www.joomla.org HTTP and HTTPS HTTP
redirect to HTTPS [image: ✅](after this PR)
docs.joomla.org HTTP and HTTPS HTTP redirect to HTTPS [image:
✅](after this PR) developer.joomla.org HTTP and HTTPS HTTP
redirect to HTTPS [image: ✅](after this PR)
volunteers.joomla.org HTTP and HTTPS HTTP redirect to HTTPS [image:
✅](after this PR) issues.joomla.org HTTP and HTTPS HTTP
redirect to HTTPS [image: ✅](after this PR)
api.joomla.org HTTP and HTTPS HTTP redirect to HTTPS [image:
✅] demo.joomla.org HTTP and HTTPS HTTP redirect to HTTPS [image:
✅] contribute.joomla.org HTTP and HTTPS Both redirect to
opensourcematters.org [image: ✅](after this PR)
update.joomla.org HTTP and HTTPS - PR related to this: #8645
#8645 help.joomla.org HTTP and
HTTPS - Code not ready yet? Same as above? shop.joomla.org HTTP and HTTPS HTTPS
has Mixed content. PR related to this: #8653
#8653 community.joomla.org HTTP
and HTTPS HTTPS has Mixed content. Site not ready yet.
resources.joomla.org HTTP and HTTPS HTTPS has Mixed content. Site not
ready yet. extensions.joomla.org HTTP and HTTPS HTTPS redirect to HTTP Site
not ready yet. forum.joomla.org HTTP and HTTPS HTTPS has protocol error. Site
not ready yet. feeds.joomla.org HTTP Feedburner Not ready yet.
build.joomla.org HTTP and HTTPS Jenkings. Certificate error Not ready yet. Other
domain in code

There are other domains used only for Unit tests to simulate errors but
doesn't really exist or are only used in unit tests, so those were not
changed:

cdn.joomla.org

base.joomla.org

test.joomla.org

xommunity.joomla.org

How to test

Check the "Files changed" in this PR and verify the changes.
More info

For checking the domains that exist in Joomla code it was used several
egrep linux commands:

egrep -R 'joomla.org' /path/to/joomla/

egrep -R 'http:(//|//)subdomain.joomla.org' /path/to/joomla/

egrep -R 'https:(//|//)subdomain.joomla.org' /path/to/joomla/

and other combinations

Suggestions or corrections are welcome.

You can view, comment on, or merge this pull request online at:

#8791
Commit Summary

Merge remote-tracking branch 'refs/remotes/joomla/staging' into
staging

Merge remote-tracking branch 'refs/remotes/joomla/staging' into
staging

Merge remote-tracking branch 'refs/remotes/joomla/staging' into
staging

Merge branch 'staging' of
https://github.com/andrepereiradasilva/joomla-cms into staging

Merge remote-tracking branch 'refs/remotes/joomla/staging' into
more-https-links

From http to https

File Changes

M README.md
https://github.com/joomla/joomla-cms/pull/8791/files#diff-0 (2)

M README.txt
https://github.com/joomla/joomla-cms/pull/8791/files#diff-1 (2)

M installation/sql/mysql/sample_learn.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-2 (6)

M installation/sql/mysql/sample_testing.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-3 (10)

M installation/sql/postgresql/sample_data.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-4 (2)

M installation/sql/postgresql/sample_learn.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-5 (6)

M installation/sql/postgresql/sample_testing.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-6 (10)

M installation/sql/sqlazure/sample_data.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-7 (2)

M installation/sql/sqlazure/sample_learn.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-8 (6)

M installation/sql/sqlazure/sample_testing.sql
https://github.com/joomla/joomla-cms/pull/8791/files#diff-9 (18)

M libraries/cms/version/version.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-10 (2)

M libraries/joomla/cache/storage/file.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-11 (2)

M libraries/joomla/document/feed/renderer/atom.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-12 (2)

M tests/system/webdriver/Pages/System/AdminPage.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-13 (4)

M tests/system/webdriver/tests/report/index.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-14 (2)

M tests/unit/stubs/database/jos_banners.csv
https://github.com/joomla/joomla-cms/pull/8791/files#diff-15 (2)

M tests/unit/stubs/database/jos_content.csv
https://github.com/joomla/joomla-cms/pull/8791/files#diff-16 (2)

M tests/unit/stubs/database/jos_finder_links.csv
https://github.com/joomla/joomla-cms/pull/8791/files#diff-17 (2)

M tests/unit/stubs/database/jos_menu.csv
https://github.com/joomla/joomla-cms/pull/8791/files#diff-18 (2)

M tests/unit/stubs/database/jos_ucm_content.csv
https://github.com/joomla/joomla-cms/pull/8791/files#diff-19 (2)

M tests/unit/suites/libraries/joomla/document/JDocumentTest.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-20 (4)

M
tests/unit/suites/libraries/joomla/document/feed/renderer/JDocumentRendererAtomTest.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-21 (2)

M
tests/unit/suites/libraries/joomla/document/html/JDocumentHTMLTest.php
https://github.com/joomla/joomla-cms/pull/8791/files#diff-22 (2)

Patch Links:

https://github.com/joomla/joomla-cms/pull/8791.patch

https://github.com/joomla/joomla-cms/pull/8791.diff

—
Reply to this email directly or view it on GitHub
#8791.

andrepereiradasilva · 2015-12-26T19:56:05Z

@mbabker
The ones that are left from help.joomla.org domain in joomla code are:

I think those can also be changed to HTTPS without issues. Do you agree?

mbabker · 2015-12-26T19:58:33Z

Yes those can change.

On Saturday, December 26, 2015, andrepereiradasilva <
notifications@github.com> wrote:

@mbabker https://github.com/mbabker
The ones that are left from help.joomla.org domain in joomla code are:

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/help/help.php#L187

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/controller/application/refreshhelp.php#L41

https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/cms/help/JHelpTest.php#L118

I think those can also be changed to HTTPS without issues. Do you agree?

—
Reply to this email directly or view it on GitHub
#8791 (comment).

mbabker · 2015-12-26T20:23:25Z

tests/system/webdriver/Pages/System/AdminPage.php

@@ -140,8 +140,8 @@
 			'Joomla Translations'	=> 'http://community.joomla.org/translations.html',
 			'Joomla Resources'		=> 'http://resources.joomla.org/',
 			'Community Portal'		=> 'http://community.joomla.org/',
-			'Security Center'		=> 'http://developer.joomla.org/security.html',
-			'Developer Resources'	=> 'http://developer.joomla.org/',
+			'Security Center'		=> 'https://developer.joomla.org/security.html',


This should actually be Security Centre and linking to https://developer.joomla.org/security-centre.html. Not 100% related to this PR but this particular test has been failing for some time if it's comparing links and text.

mbabker · 2015-12-26T20:27:36Z

As for the test case involving cdn.joomla.org it's validating a behavior in that class' API and not reliant on a "real" page. You can try changing it to HTTPS but I think the protocol is dependent on the injected config values in that test case IIRC so it might end up failing without additional changes.

andrepereiradasilva · 2015-12-26T20:43:18Z

@mbabker thanks for your comments

Made the two changes and travis accepted them without problems.

We also have the joom.la domain (only in https://github.com/joomla/joomla-cms/blob/staging/tests/unit/suites/libraries/joomla/application/JApplicationWebTest.php) that i think is some kind of URI shortener service, right?

By the way, the certificate is incorrect in that domain.

infograf768 · 2015-12-27T15:59:01Z

Looking at this patch and specially the tests/unit/stubs/database/...
I found 27 occurences of these unknown characters

�*�

mbabker · 2015-12-27T16:19:37Z

It's some kind of quirk unrelated to this patch (it's actually a \u0 character according to Chrome). This screenshot is me putting an echo serialize($item);die; line in before rows are written to the table where those characters are being found.

mbabker · 2015-12-27T16:27:16Z

It's PHP's behavior actually... http://php.net/manual/en/function.serialize.php

Object's private members have the class name prepended to the member name; protected members have a '*' prepended to the member name. These prepended values have null bytes on either side.

infograf768 · 2015-12-27T16:37:07Z

Thanks Michael.

andrepereiradasilva · 2015-12-27T17:47:19Z

Ok. So all fine.

Replace: http://community.joomla.org/events.html for: https://events.joomla.org/

andrepereiradasilva · 2016-03-12T16:30:44Z

closed as comments above, new PR will be made.

andrepereiradasilva and others added 6 commits November 23, 2015 10:07

Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging

78c2f3a

Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging

51113e7

Merge remote-tracking branch 'refs/remotes/joomla/staging' into staging

5021989

Merge branch 'staging' of https://github.com/andrepereiradasilva/joom…

63c45ef

…la-cms into staging

Merge remote-tracking branch 'refs/remotes/joomla/staging' into more-…

21e1a6e

…https-links

From http to https

c1e41e3

joomla-cms-bot added PR-staging Unit/System Tests labels Dec 26, 2015

andrepereiradasilva mentioned this pull request Dec 26, 2015

Point Atom Feed generator to Joomla site in https #8789

Closed

some missing in json format

1e620cc

andrepereiradasilva changed the title ~~Replace joomla.org (and subdomains) HTTP links for HTTPS links (where possible)~~ Replace leftover joomla.org (and subdomains) HTTP links for HTTPS links (where possible) Dec 26, 2015

Update help.joomla.org to HTTPS too

0b3eba5

mbabker reviewed Dec 26, 2015
View reviewed changes

andrepereiradasilva added 2 commits December 26, 2015 20:32

updated security center URI

8a68a8c

cdn.joomla.org to HTTPS

e605e96

update string size

874ad17

Replace events site URI

a467b5b

Replace: http://community.joomla.org/events.html for: https://events.joomla.org/

brianteeman mentioned this pull request Mar 12, 2016

Move external domains links and references to HTTPS (where possible) #8794

Closed

andrepereiradasilva closed this Mar 12, 2016

andrepereiradasilva deleted the more-https-links branch May 4, 2016 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace leftover joomla.org (and subdomains) HTTP links for HTTPS links (where possible) #8791

Replace leftover joomla.org (and subdomains) HTTP links for HTTPS links (where possible) #8791

andrepereiradasilva commented Dec 26, 2015

wojsmol commented Dec 26, 2015

mbabker commented Dec 26, 2015

Suggestions or corrections are welcome.

andrepereiradasilva commented Dec 26, 2015

mbabker commented Dec 26, 2015

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/help/help.php#L187

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/controller/application/refreshhelp.php#L41

mbabker Dec 26, 2015

mbabker commented Dec 26, 2015

andrepereiradasilva commented Dec 26, 2015

infograf768 commented Dec 27, 2015

mbabker commented Dec 27, 2015

mbabker commented Dec 27, 2015

infograf768 commented Dec 27, 2015

andrepereiradasilva commented Dec 27, 2015

andrepereiradasilva commented Mar 12, 2016

Replace leftover joomla.org (and subdomains) HTTP links for HTTPS links (where possible) #8791

Replace leftover joomla.org (and subdomains) HTTP links for HTTPS links (where possible) #8791

Conversation

andrepereiradasilva commented Dec 26, 2015

Description

List of joomla.org domains (found in code and completly https with this PR)

List of joomla.org domains (found in code but will have to wait for a future PR)

Other domain in code

How to test

More info

wojsmol commented Dec 26, 2015

mbabker commented Dec 26, 2015

Suggestions or corrections are welcome.

andrepereiradasilva commented Dec 26, 2015

mbabker commented Dec 26, 2015

https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/help/help.php#L187

https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/controller/application/refreshhelp.php#L41

mbabker Dec 26, 2015

Choose a reason for hiding this comment

mbabker commented Dec 26, 2015

andrepereiradasilva commented Dec 26, 2015

infograf768 commented Dec 27, 2015

mbabker commented Dec 27, 2015

mbabker commented Dec 27, 2015

infograf768 commented Dec 27, 2015

andrepereiradasilva commented Dec 27, 2015

andrepereiradasilva commented Mar 12, 2016