New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove administrator deprecated JVersion calls #8932
Closed
andrepereiradasilva
wants to merge
9
commits into
joomla:staging
from
andrepereiradasilva:jversion-deprecated
Closed
Remove administrator deprecated JVersion calls #8932
andrepereiradasilva
wants to merge
9
commits into
joomla:staging
from
andrepereiradasilva:jversion-deprecated
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepereiradasilva
changed the title
Remove administrater mod_version deprecated JVersion calls
Remove administrator mod_version deprecated JVersion calls
Jan 18, 2016
This was referenced Jan 18, 2016
andrepereiradasilva
changed the title
Remove administrator mod_version deprecated JVersion calls
Remove administrator deprecated JVersion calls
Jan 18, 2016
I have tested this item ✅ successfully on dcdd24a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8932. |
I have tested this item ✅ successfully on dcdd24a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8932. |
RTC - thanks This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8932. |
This has broken mod_version |
Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the usage of deprecated JVersion methods inside admin mod_version (the one that puts the joomla version in the bottom right corner of the admin panel) and from install languages.
The old usage was deprecated in #7217
#8935, #8925 and #8932 removes most of deprecated log messages in Joomla core.
How to test.
Part 2: