Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove administrator deprecated JVersion calls #8932

Conversation

andrepereiradasilva
Copy link
Contributor

Description

This PR removes the usage of deprecated JVersion methods inside admin mod_version (the one that puts the joomla version in the bottom right corner of the admin panel) and from install languages.
The old usage was deprecated in #7217

#8935, #8925 and #8932 removes most of deprecated log messages in Joomla core.

How to test.

  • Install patch.
  • Check if in the bottom right corner of your joomla admin panel if version is ok
  • Go to modules, select "Administrator" modules and edit the "Joomla Version".
  • Test the 3 options and check if they are all ok.
  • Check also if in the debug console there is no deprecated message

Part 2:

  • Go to install languages
  • Check there are no JVersion deprecated messages and everything works fine

@andrepereiradasilva andrepereiradasilva changed the title Remove administrater mod_version deprecated JVersion calls Remove administrator mod_version deprecated JVersion calls Jan 18, 2016
@andrepereiradasilva andrepereiradasilva changed the title Remove administrator mod_version deprecated JVersion calls Remove administrator deprecated JVersion calls Jan 18, 2016
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on dcdd24a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8932.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on dcdd24a

It works OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8932.

@brianteeman
Copy link
Contributor

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8932.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 27, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Jan 27, 2016
@wilsonge wilsonge closed this in 7719186 Jan 27, 2016
@andrepereiradasilva andrepereiradasilva deleted the jversion-deprecated branch January 27, 2016 22:46
@infograf768
Copy link
Member

This has broken mod_version
( ! ) Fatal error: Can't use method return value in write context in ROOT/administrator/modules/mod_version/helper.php on line 36

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 28, 2016
@infograf768
Copy link
Member

@infograf768
Copy link
Member

Please test
#9003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants