Fix Drag&Drop sorting

[renekorss]

Fix sorting if there is items with different heights. Bug occured only for moving higher item up. Now respects height of moved item.

fixes #8861

[brianteeman]

I can not replicate this issue

[renekorss]

@brianteeman You created on article with very long title and moving it up results in ordering 1, 2, 3? Not 1, 1, 3?

[brianteeman]

Yes and Yes

[brianteeman]

After playing a bit more and doublechecking with the database entries I was able to get it to misbehave once - where the DB entry did not match the visual display.

I applied the patch and retested and couldnt replicate the bug anymore so this is a good test

[brianteeman]

To anyone else testing make sure you check the value of the ordering column in the database

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[svenbluege]

With this fix applied I can't reproduce the issue in #8861. I confirm this fix is working.

[wojsmol]

@svenbluege Please mark test results on https://issues.joomla.org/tracker/joomla-cms/9049

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[svenbluege]

I have tested this item ✅ successfully on 4b8325e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[svenbluege]

@wojsmol Done. First time for me so let me know if there is more todo.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[wojsmol]

@svenbluege Now everything is correctly.

[brianteeman]

I have tested this item ✅ successfully on 4b8325e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[brianteeman]

RTC - thanks

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[wilsonge]

@renekorss There are conflicts here - can you please fix them :) If not then to confirm https://github.com/joomla/joomla-cms/pull/9049/files#diff-0f3028a8e62b1bde4dd60f2a5af107b0R225 is the only line that has changed right?

[renekorss]

@wilsonge Yes, correct. I can fix it, when I get to computer.

[joomla-cms-bot]

This PR has received new commits.

CC: @brianteeman, @svenbluege

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9049.}

[renekorss]

@wilsonge Conflicts fixed.