Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded translations from rel attribute options. #9300

Merged
merged 1 commit into from
Mar 4, 2016

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Mar 4, 2016

Pull Request for discussion in PR #9282 .

Summary of Changes

Removes translation strings for the options in the new rel attribute parameter. Those aren't needed because we don't need to have those translated.

Testing Instructions

Make sure you can still see and can select each option.

@Bakual
Copy link
Contributor Author

Bakual commented Mar 4, 2016

Original testing instructions apply here as well:


This PR add the ability to set "rel" attribute of a link when you setup a menu item type of external url.
SEO purpose.

Testing Instructions

Before patch

Create a menu item type of "External url", go to tab "Link type", there is no way to setup an rel attribute.

After patch
  • Create a menu item type of "External url", add title, link (eg: https://www.google.fr/) then go to tab "Link type", there is a field "Link Rel Attribute" to setup (eg: Nofollow);
  • Save.
  • Go to frontend, look at html rendered by a module menu (eg: ul > li > a)

this should seem like this:

<a href="https://www.google.fr/" rel="nofollow">My external url</a>

Try switching different rel value, for "None" there is no rel attribute:

<a href="https://www.google.fr/">My external url</a>

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 849fe43

ok here. should go in now. @wilsonge


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9300.

@infograf768
Copy link
Member

can be merged on review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9300.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 4, 2016
wilsonge added a commit that referenced this pull request Mar 4, 2016
Remove unneeded translations from rel attribute options.
@wilsonge wilsonge merged commit 9e7becb into joomla:staging Mar 4, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Mar 4, 2016
@Bakual Bakual deleted the RemoveTranslatedOptions branch March 4, 2016 18:37
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants