Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for MCrypt in SysInfo #9532

Merged
merged 2 commits into from
Apr 12, 2016
Merged

Conversation

andrepereiradasilva
Copy link
Contributor

Pull Request for Issue #9507.

Summary of Changes

Adds php mcrypt extension information to sysinfo.

image

Testing Instructions

  1. Use Joomla 3.5.0
  2. Aply patch
  3. Go to sysinfo and check if in php settings separator there is a new line "MCrypt Enabled"

Additional information

PR for adding this info to the installer: #9508

@@ -112,6 +112,7 @@ COM_ADMIN_LOG_DIRECTORY="(Log folder)"
COM_ADMIN_MAGIC_QUOTES="Magic Quotes"
COM_ADMIN_MAX_INPUT_VARS="Maximum Input Variables"
COM_ADMIN_MBSTRING_ENABLED="Multibyte String (mbstring) Enabled"
COM_ADMIN_MCRYPT_ENABLED="MCrypt Enabled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Mcrypt not MC

@mbabker
Copy link
Contributor

mbabker commented Mar 22, 2016

Aside from the language string comment, looks fine to me.

@brianteeman
Copy link
Contributor

Thanks for correcting the string

@brianteeman brianteeman added this to the Joomla 3.5.2 milestone Mar 23, 2016
@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.5.2 milestone Mar 23, 2016
@brianteeman brianteeman added this to the Joomla 3.5.2 milestone Mar 23, 2016
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 5982059


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9532.

@brianteeman
Copy link
Contributor

Taking @mbabker comment as a successful test setting to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9532.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 29, 2016
@rdeutz rdeutz merged commit e7ca464 into joomla:staging Apr 12, 2016
@andrepereiradasilva andrepereiradasilva deleted the sysinfo-mcrypt branch April 12, 2016 21:08
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants