-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mod_breadcrumbs.xml #9540
Conversation
PR for #9521 Proposal to set the default install value to disabled for mod_breadcrumbs and also cache time to 0 as belts and braces. Still need to check the sample data install
Yep, it also needs chnages in the joomla.sql for each db:
|
Yes in all db drivers |
Daft question, how do I update my PR? |
Just update your branch and the pull request will be updated automatically This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540. |
you have to update the files in your "patch-2" branch any changes you made in that branch will automatically will be in this PR. |
I think that's all the files that needed adjusting, I can't find the location for adjusting the tool tip for caching on the advanced tab, it anyone can point me in the right direction... This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540. |
that string (COM_MODULES_FIELD_CACHING_DESC) is global for all modules. the location is https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_modules.ini#L37 |
@andrepereiradasilva Thanks for the pointer, I was thinking it was possibly going to be a global string, it's beyond my ability to set it up to something separate for the one module. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540. |
I have tested this item ✅ successfully on 760bfcb This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540. |
I have tested this item ✅ successfully on 760bfcb This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540. |
Merged - thanks! |
Pull Request for Issue #9521 .
Summary of Changes
set default install value for mod_breadcrumbs caching value to off '0' also caching time to '0' so that it has to be a definite wish to enable it.
Testing Instructions
This PR will only have an effect from a clean install on selecting a new breadcrumb menu, going to the advanced settings cache should by default be disabled and caching time 0
I need to find the sample install data and check to see if it's enabled at all please hold off testing at the moment, but I welcome comments.