Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mod_breadcrumbs.xml #9540

Merged
merged 20 commits into from
Apr 12, 2016
Merged

Update mod_breadcrumbs.xml #9540

merged 20 commits into from
Apr 12, 2016

Conversation

Twincarb
Copy link
Contributor

Pull Request for Issue #9521 .

Summary of Changes

set default install value for mod_breadcrumbs caching value to off '0' also caching time to '0' so that it has to be a definite wish to enable it.

Testing Instructions

This PR will only have an effect from a clean install on selecting a new breadcrumb menu, going to the advanced settings cache should by default be disabled and caching time 0

I need to find the sample install data and check to see if it's enabled at all please hold off testing at the moment, but I welcome comments.

PR for #9521
Proposal to set the default install value to disabled for mod_breadcrumbs and also cache time to 0 as belts and braces.
Still need to check the sample data install
@infograf768
Copy link
Member

Yep, it also needs chnages in the joomla.sql for each db:

(17, 51, 'Breadcrumbs', '', '', 1, 'position-2', 0, '0000-00-00 00:00:00', '0000-00-00 00:00:00', '0000-00-00 00:00:00', 1, 'mod_breadcrumbs', 1, 1, '{"moduleclass_sfx":"","showHome":"1","homeText":"","showComponent":"1","separator":"","cache":"1","cache_time":"900","cachemode":"itemid"}', 0, '*'),

@andrepereiradasilva
Copy link
Contributor

Yes in all db drivers
And it should be changed in sample data database SQL too.

@Twincarb
Copy link
Contributor Author

Daft question, how do I update my PR?

@Twincarb Twincarb closed this Mar 23, 2016
@Twincarb Twincarb reopened this Mar 23, 2016
@brianteeman
Copy link
Contributor

Just update your branch and the pull request will be updated automatically


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.

@andrepereiradasilva
Copy link
Contributor

you have to update the files in your "patch-2" branch
https://github.com/Twincarb/joomla-cms/tree/patch-2

any changes you made in that branch will automatically will be in this PR.

@Twincarb
Copy link
Contributor Author

I think that's all the files that needed adjusting, I can't find the location for adjusting the tool tip for caching on the advanced tab, it anyone can point me in the right direction...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.

@andrepereiradasilva
Copy link
Contributor

that string (COM_MODULES_FIELD_CACHING_DESC) is global for all modules.

the location is https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_modules.ini#L37

@Twincarb
Copy link
Contributor Author

@andrepereiradasilva Thanks for the pointer, I was thinking it was possibly going to be a global string, it's beyond my ability to set it up to something separate for the one module.
The db drivers, which files am I looking for, all of the sql folder files are updated.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 760bfcb

Tested by code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 760bfcb


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9540.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 25, 2016
@wilsonge wilsonge merged commit 19270af into joomla:staging Apr 12, 2016
@wilsonge wilsonge added this to the Joomla 3.5.2 milestone Apr 12, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 12, 2016
@wilsonge
Copy link
Contributor

Merged - thanks!

@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants