Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[searchtools] Integrate searchtools no results message in the searchtools layout #9738

Merged
merged 3 commits into from Apr 12, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

Pull Request for Improvement.

Summary of Changes

To make overrides simpler, this PR integrates the searchtools no results info in searchtools layout. This message is part of the searchtools so it should be there.

As a PoC i applied this only in com_cache cache view.

I also changed the background color of the searchtools no results message to be a info, not a warning. This change is only is the "new" layout, the "old" stays the same.
image

Advantage
  • After this PR you can now change all the searchtools look (including no results info) with a simple layout override.
  • You retain the ability to change the no result text by passing the noResultsText variable to the layout.

Testing Instructions

  1. Use latest staging
  2. Apply patch
  3. Go to "System -> Clear cache" (clear the cache if exists)
  4. You will see a blue no results message.
  5. Now to test B/C go to any other view (articles for instance) and search for something that does not return results (you will see the "old" yellow message)

Observations

B/C is preserved as the old method continues to work fine.

If this gets to RTC state i intend to make the changes needed in all the other views.

@brianteeman
Copy link
Contributor

lol - pretend==> intend


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 158cec6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.

@andrepereiradasilva
Copy link
Contributor Author

ehheheh. Don't make fun of my non native english mistakes! I would like to see you write in portuguese :)

@MATsxm
Copy link

MATsxm commented Apr 5, 2016

I have tested this item ✅ successfully on 158cec6

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9738.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 5, 2016
@brianteeman brianteeman added this to the Joomla 3.5.2 milestone Apr 6, 2016
@rdeutz rdeutz merged commit de00d4b into joomla:staging Apr 12, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 12, 2016
@andrepereiradasilva andrepereiradasilva deleted the searchtools-improvement branch April 12, 2016 23:37
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants