New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[com_installer] [updatesites] Add options to delete and rebuild update sites #9744
[com_installer] [updatesites] Add options to delete and rebuild update sites #9744
Conversation
@@ -131,6 +131,12 @@ COM_INSTALLER_MSG_UPDATE_NOUPDATES="There are no updates available at the moment | |||
COM_INSTALLER_MSG_UPDATE_SITES_COUNT_CHECK="Some update sites are disabled. You may want to check the <a href="_QQ_"%s"_QQ_">Update Sites Manager</a>." | |||
COM_INSTALLER_MSG_UPDATE_SUCCESS="Updating %s was successful." | |||
COM_INSTALLER_MSG_UPDATE_UPDATE="Update" | |||
COM_INSTALLER_MSG_UPDATESITES_DELETE_ERROR="And error as occured while trying to delete "_QQ_"%s"_QQ_" update site: %s." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error has...
ok still need some changes here, plus resolving the plural forms. discovered some bugs. will tell when ready. |
I suggest to slightly change the constants for the plural strings, i.e adding
to
|
Thanks @infograf768 that was what I had suggested before the N |
I have tested this item ✅ successfully on 17db21e All good (once the language string key is updated) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
please don't test yet i has some bugs still. |
Really? Every test I could think of worked |
problems still to solve (that i know of):
|
Accredited Joomla! Translations update site cannot be deleted. In addition its a protected extension so cant be deleted |
@brianteeman Explaining, for what i know, and correct me if i'm wrong: A language package install 3 extensions in the database:
The en-GB language pack (comes by default) somehow only has two extensions in the database...
See https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L618-L619 Since the update servers are declared in the pkg manifest, if somehow deleted, will not be reconstructed in this PR. So this is not related to this PR, this PR does not readd the en-GB update site after "accidental" delete because, as said, the pkg_en-GB extension does not exist, by default, in joomla database. But from a coherence point of view, if a manifest exists, the extension should exist in the database. In other words, IMHO it should exist a blocked en-GB package extension in the database on joomla install and the udpate site should point to that extension (as all language packs do). Remember you have blocked extension in the database for all other manifest files, including joomla core, joomla update, etc. |
Not 100% sure I understand your last sentence but as for the rest it really is beyond the scope of this PR |
@brianteeman |
yes, it's out of the scope of this PR.
Some examples: Joomla Core: All logic Joomla Update: All logic en-GB language package: ?
Something doesn't seem right ... Put ok, let's concentrate in the PR and check that later. |
Yes, but in another PR.
This PR doesn't allow to delete any update site that has
Not only, the update site extension id should be linked en-Gb package too (since it's in the en-GB package manifest that exists the update server URI). |
As this PR does not allow you to delete that update site I really think its a non-issue |
Yes, it's not an issue because of the special treatment that exists in en-GB, it's just an inconsistency i discovered in this PR. I will not fix this is this PR. So let's concentrate in this PR. Will do the rest of the changes and tell when is finished. |
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
ok, now should be ok. |
I dont understand the comment about a discovered extension not being installed. If I click on discover and install an extension then it is installed and if it has an update server in the xml it is added to the update sites This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
I realise now you meant not to parse the extensions that are listed in Discover but have not been installed yet This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
I have tested this item ✅ successfully on 4d26e51 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
I have tested this item ✅ successfully on 4d26e51 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
I have tested this item ✅ successfully on 4d26e51 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9744. |
Pull Request for Issue #8512.
Summary of Changes
After updating Joomla and extensions a lot of times (since 1.7) we get a lot of obsolete update sites from domain changes, url changes, etc that extension developers forget to delete on uninstall.
This makes searching for updates more slow. Right now we can disable the update sites, but we cannot delete or even rebuild the update sites table.
This PR adds two new options to com_installer updates sites view: delete and rebuild
Testing Instructions
Observations
Code revisions, improvements and suggestions are welcomed.