FIX: truncating a string fail when last space is within a tag #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related tracker item: #30552, Patch included |
|
Thanks for coding this, Robert! For anyone interested, here's the direct link to tracker item on JoomlaCode: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when you have a string "..... this is text
Here is the limit" and the limit is within "Here". The next space is the space between
(there could also be any other tag with spaces) what is wrong because we end up with not valid html code. The right place is the space between "is" and "text".
This fix is checking if the place is within a tag and moves it before the tag.