Missing space in Mod custom

[N6REJ]

Pull Request for Issue # .

Summary of Changes

added the missing space between 'custom' and 'suffix'

Testing Instructions

create a custom module, look at the module class and you'll see "custom"
add a class suffix and you'll see "customYOURSUFFIX" this is not as expected, nor consistent with the rest of the module class suffix behaviors.
after this patch you'll see that it is now "custom YOURSUFFIX"

[N6REJ]

not sure why its saying 3 commits but this is correct.

[mbabker]

This is the expected (even if anti-UX) behavior. Leave no space and you
can completely remove the custom class and use it as a prefix for the
user's input class. Add a space and it adds additional class(es) to the
div.

On Tuesday, April 12, 2016, Bear notifications@github.com wrote:

Pull Request for Issue # .
Summary of Changes

added the missing space between 'custom' and 'suffix'
Testing Instructions

create a custom module, look at the module class and you'll see "custom"
add a class suffix and you'll see "customYOURSUFFIX" this is not as
expected, nor consistent with the rest of the module class suffix behaviors.

after this patch you'll see that it is now "custom YOURSUFFIX"

You can view, comment on, or merge this pull request online at:

#9883
Commit Summary

• missing alpha.png
• Merge origin/staging into staging
• fixes missing space between 'custom' and suffix class names.

File Changes

• M modules/mod_custom/tmpl/default.php
  https://github.com/joomla/joomla-cms/pull/9883/files#diff-0 (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/9883.patch
• https://github.com/joomla/joomla-cms/pull/9883.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#9883

[ggppdk]

@N6REJ
it is like this in all modules, not just for this module
and it has been always like this

and it is consistent with the parameter name "...sfx" and description
plus this change would cancel custom styling rules for existing websites (B/C break)

[brianteeman]

Closing for the reasons stated above

[N6REJ]

the problem is that its inconsistent with the rest of class suffix's. before it was like this for ALL suffix's ( components ) and modules, or am I mistaken?

[ggppdk]

You can do a recursive text search in the modules folder

<?php echo $moduleclass_sfx

you will see that all

• Joomla modules
• majority (but not all (their choice ...)) of 3rd party modules

do not add space

and if you want to add a new class to it, just use the parameter like this:
_mySuffix myClassName

thus this:
custom

will become:
custom_mySuffix myClassName

[Mocha365]

It's 2017 and just found this Pull Request (which I see is closed), so am I missing something or has the missing space been put back in as missing? Joomla 3.7.4 has most if not all modules "still" missing the space. Example of what is still showing

<div class="custom<?php echo $moduleclass_sfx; ?>

There's no space after "custom" or in other modules. Right now, adding a class suffix to any module results in:

moduletablemyclass

instead of:

moduletable myclass

[mbabker]

As stated above, it's an explicit design decision. With no space, you can suffix the class that comes before it in a layout (in this case, the custom class) which would let you completely remove that class from things, or you can prefix your input with a space and add additional classes.