-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number validation as global handler #9998
Conversation
Could you use 4 spaces as described here? |
@piotr-cz 😆 |
I'd love to, but probably not in this PR, because it would break git diffs (all lines would show as changed). Looks like 2x tabs or eventually 8x space would fit current CS here (ATM there is space + tab + space + tab 😄 ). |
Hm, why it names "number" validation? I see only some "range" validation. |
Need a PR for add |
@jackkum Sorry I dont understand your last comment This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9998. |
@brianteeman Sorry for my English. |
Can you please mention the Both scenario before patch and after patch, as i tested and it seems working same in both cases This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9998. |
I have tested this PR in Joomla! 3.6.4, before patch and after patch the session field is working same in bath scenarios. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/9998. |
@jackkum can you please fix the conflicts? |
I have tested this item ✅ successfully on d2a18fb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/9998. |
@jackkum Can you please fix conflict in media/system/js/validate.js file? |
@jackkum it has been six months since the first request to resolve the merge conflicts. Also as several people have reported that they cannot see any difference after applying the PR I am going to close this at this time. It can always be reopened if you resolve the conflicts and address the comments about no change after this PR |
Pull Request for Issue #5619 .
Summary of Changes
Testing Instructions
You should see error (red border around and title on mouseover)
This PR add handler as global, only for session lifetime (com_config) here: #9997