Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add deleted & required _unix2DOSTime method #1563

Merged
merged 1 commit into from Oct 8, 2012

Conversation

Projects
None yet
3 participants
Contributor

phproberto commented Oct 1, 2012

Method _unix2DOSTime was in Platform 11.1 but does not exist actually.

Is required by the method _addToZIPFile:

    // Get the hex time.
    $dtime = dechex($this->_unix2DosTime($ftime)); 

Was removed intentionally? If so what is the replacement?

We have to re-add the method or replace its call.

Contributor

eddieajau commented Oct 8, 2012

Wouldn't you use the native 5.3 support in favour of JArchiveZip? See http://php.net/manual/en/book.zip.php

Contributor

phproberto commented Oct 8, 2012

@eddieajau It isn't my code. I was trying to fix this issue reported on joomla tracker:

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29411

If the user has to use native PHP functions why don't fully delete this class? If the library is available it has to work even if it's there only for backward compatibility.

There is a method in this class that is calling another one that has been deleted. We should remove it or fix it.

Contributor

LouisLandry commented Oct 8, 2012

I do think we should be looking into going "native" where possible, but this appears to simply fix a regression. Thanks a bunch Roberto!

LouisLandry added a commit that referenced this pull request Oct 8, 2012

Merge pull request #1563 from phproberto/unix2dostime
Add deleted & required _unix2DOSTime method

@LouisLandry LouisLandry merged commit ae42376 into joomla:staging Oct 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment