Skip to content
This repository has been archived by the owner on Nov 26, 2017. It is now read-only.

Add deleted & required _unix2DOSTime method #1563

Merged
merged 1 commit into from
Oct 8, 2012
Merged

Add deleted & required _unix2DOSTime method #1563

merged 1 commit into from
Oct 8, 2012

Conversation

phproberto
Copy link
Contributor

Method _unix2DOSTime was in Platform 11.1 but does not exist actually.

Is required by the method _addToZIPFile:

    // Get the hex time.
    $dtime = dechex($this->_unix2DosTime($ftime)); 

Was removed intentionally? If so what is the replacement?

We have to re-add the method or replace its call.

@eddieajau
Copy link
Contributor

Wouldn't you use the native 5.3 support in favour of JArchiveZip? See http://php.net/manual/en/book.zip.php

@phproberto
Copy link
Contributor Author

@eddieajau It isn't my code. I was trying to fix this issue reported on joomla tracker:

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=29411

If the user has to use native PHP functions why don't fully delete this class? If the library is available it has to work even if it's there only for backward compatibility.

There is a method in this class that is calling another one that has been deleted. We should remove it or fix it.

@LouisLandry
Copy link
Contributor

I do think we should be looking into going "native" where possible, but this appears to simply fix a regression. Thanks a bunch Roberto!

LouisLandry added a commit that referenced this pull request Oct 8, 2012
Add deleted & required _unix2DOSTime method
@LouisLandry LouisLandry merged commit ae42376 into joomla:staging Oct 8, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants