Fixed issue with JFormHelper:loadClass() including only first filename match

[ghost]

Now it includes all matched files till it finds the required classname. Fixes #455

[eddieajau]

Peter, I think all we need is the unit test to validate the changes. Thanks in advance.

[ghost]

Great. Just to add:
This is just a quickfix till this whole thing is handled in a better lower-level way as mentioned by Louis (using JLoader).
So it might be good to add something along those lines in the comment near this code block...

[joomla-jenkins]

Unit testing complete. There were 0 failures and 1 errors from 1683 tests and 10557 assertions.
Checkstyle analysis reported 453 warnings and 6 errors.

[ghost]

Any info on what the errors are? Anything I can/should do?

[elinw]

Peter do you have phpunit installed? You can run the locally. There are instrutions on the wiki and here
https://github.com/joomla/joomla-platform/blob/staging/docs/manual/appendices/analysis.xml.

[ghost]

No, I haven't. Pretty new to this. So I'll look into it...

[joomla-jenkins]

Build triggered by changes to the base.

Unit testing complete. There were 0 failures and 0 errors from 1683 tests and 10559 assertions.
Checkstyle analysis reported 453 warnings and 2 errors.

[ghost]

So all is ok?

The Checkstyle warnings/errors, does that concern these changes? Can't imagine these few lines generating 453 warnings :S

[elkuku]

The warnings come from all over the place - the errors shouldn't ;)

Checkstyle error details:
libraries/joomla/form/helper.php:202
Concat operator must be surrounded by spaces
libraries/joomla/form/helper.php:203
Expected "foreach (...)\n...{\n"; found "foreach(...)\n...{\n"

[joomla-jenkins]

Build triggered by changes to the head.

The tests completed but there was a problem parsing the report.
Unit testing complete. There were 0 failures and 0 errors from 1742 tests and 10618 assertions.
Checkstyle analysis reported 453 warnings and 29 errors.

[ghost]

Sorry, I don't understand. Is everyone using different coding styles?

[elinw]

The 453 are the same ones everyone has and have nothing to do with your code. But if the numbers go up it's due to your code.

[ghost]

Yes, but what about the 29 errors?
"Checkstyle analysis reported 453 warnings and 29 errors."

[elkuku]

I believe, that's a mistake. From my POV your code is OK
Please be patient ;)

[ghost]

Ok, great. I am patient. Just worried I am doing stuff wrong. :)

[LouisLandry]

Best I can tell this is all good. Going to merge it now. Thanks Peter.