Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Admin Module Latest #3174

Closed
jgerman-bot opened this issue May 1, 2024 · 0 comments · Fixed by #3177
Closed

[5.2] Admin Module Latest #3174

jgerman-bot opened this issue May 1, 2024 · 0 comments · Fixed by #3177

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#43216 Here are the upstream changes:

Click to expand the diff!
diff --git a/administrator/language/en-GB/mod_latest.ini b/administrator/language/en-GB/mod_latest.ini
index 4ed7b52f030c0..20bb62ff8cd67 100644
--- a/administrator/language/en-GB/mod_latest.ini
+++ b/administrator/language/en-GB/mod_latest.ini
@@ -14,6 +14,8 @@ MOD_LATEST_FIELD_VALUE_AUTHORS_BY_ME="Added or modified by me"
 MOD_LATEST_FIELD_VALUE_AUTHORS_NOT_BY_ME="Not added or modified by me"
 MOD_LATEST_FIELD_VALUE_ORDERING_ADDED="Recently Added First"
 MOD_LATEST_FIELD_VALUE_ORDERING_MODIFIED="Recently Modified First"
+MOD_LATEST_HEADING_DATE_CREATED="Date Created"
+MOD_LATEST_HEADING_DATE_MODIFIED="Date Modified"
 MOD_LATEST_LATEST_ITEMS="Latest Items"
 MOD_LATEST_NO_MATCHING_RESULTS="No Matching Results"
 MOD_LATEST_TITLE="Recently Created Articles"
diff --git a/administrator/modules/mod_latest/src/Helper/LatestHelper.php b/administrator/modules/mod_latest/src/Helper/LatestHelper.php
index 617d70fd8dd50..afab1bb8a8a20 100644
--- a/administrator/modules/mod_latest/src/Helper/LatestHelper.php
+++ b/administrator/modules/mod_latest/src/Helper/LatestHelper.php
@@ -41,7 +41,7 @@ public static function getList(Registry $params, ArticlesModel $model)
         $user = Factory::getUser();
 
         // Set List SELECT
-        $model->setState('list.select', 'a.id, a.title, a.checked_out, a.checked_out_time, ' .
+        $model->setState('list.select', 'a.id, a.title, a.checked_out, a.checked_out_time, a.modified,' .
             ' a.access, a.created, a.created_by, a.created_by_alias, a.featured, a.state, a.publish_up, a.publish_down');
 
         // Set Ordering filter
diff --git a/administrator/modules/mod_latest/tmpl/default.php b/administrator/modules/mod_latest/tmpl/default.php
index f77973ade2cd1..572dd93e4a9c6 100644
--- a/administrator/modules/mod_latest/tmpl/default.php
+++ b/administrator/modules/mod_latest/tmpl/default.php
@@ -25,7 +25,9 @@
                 <th scope="col" class="w-20"><?php echo Text::_('JSTAGE'); ?></th>
             <?php endif; ?>
             <th scope="col" class="w-20"><?php echo Text::_('JAUTHOR'); ?></th>
-            <th scope="col" class="w-20"><?php echo Text::_('JDATE'); ?></th>
+            <th scope="col" class="w-20">
+                <?php echo ($params->get('ordering', 'c_dsc') == 'm_dsc') ? Text::_('MOD_LATEST_HEADING_DATE_MODIFIED') : Text::_('MOD_LATEST_HEADING_DATE_CREATED'); ?>
+            </th>
         </tr>
     </thead>
     <tbody>
@@ -53,7 +55,7 @@
                 <?php echo $item->author_name; ?>
             </td>
             <td>
-                <?php echo HTMLHelper::_('date', $item->created, Text::_('DATE_FORMAT_LC4')); ?>
+                <?php echo ($params->get('ordering', 'c_dsc') == 'm_dsc') ? HTMLHelper::_('date', $item->modified, Text::_('DATE_FORMAT_LC4')) : HTMLHelper::_('date', $item->created, Text::_('DATE_FORMAT_LC4')); ?>
             </td>
         </tr>
             <?php endforeach; ?>
tecpromotion added a commit to tecpromotion/joomla that referenced this issue May 1, 2024
add translation
@tecpromotion tecpromotion linked a pull request May 1, 2024 that will close this issue
zero-24 pushed a commit that referenced this issue May 13, 2024
* add new strings

* fix #3174

add translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

4 participants