Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Admin Module Latest #43216

Merged
merged 10 commits into from Apr 30, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Apr 5, 2024

Summary of Changes

The admin module Articles - Latest displays a list of recently added content. This is really useful on the dashboards. (especially when used together with the author filter)

The list can be sorted by created or modified date but it will only ever display the created date.

This PR changes the date column to display created or modified depending on the sort param.

Testing Instructions

Create some articles with varying created and modified dates
Change the ordering option in the module

Actual result BEFORE applying this Pull Request

The list of articles are sorted based on the selected date but the displayed date is always the created date

Expected result AFTER applying this Pull Request

The list of articles are sorted based on the selected date but the displayed date is the same as the sort

image

image

No new param

I guess this could have been done by adding a new param for the displayed date but

  1. it is more logical that you want to display the date you are sorting by
  2. because the modified date is now available you can create a template override to display the date how you want - even to display both dates

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

The admin module Articles - Latest displays a list of recently added content. This is really useful on the dashboards. (especially when used together with the author filter)

The list can be sorted by created or modified date but it will only ever display the created date.

This PR changes the date column to display created or modified depending on the sort param.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Apr 5, 2024
@Quy
Copy link
Contributor

Quy commented Apr 5, 2024

I have tested this item ✅ successfully on ce05fd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43216.

1 similar comment
@carlitorweb
Copy link
Member

I have tested this item ✅ successfully on ce05fd6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43216.

@Quy
Copy link
Contributor

Quy commented Apr 5, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43216.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 5, 2024
@pe7er pe7er self-assigned this Apr 23, 2024
@pe7er pe7er enabled auto-merge (squash) April 30, 2024 07:48
@pe7er pe7er merged commit d8650b4 into joomla:5.2-dev Apr 30, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 30, 2024
@pe7er
Copy link
Contributor

pe7er commented Apr 30, 2024

Thanks @brianteeman !

@brianteeman
Copy link
Contributor Author

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants