Add support for s-maxage #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an optional additional shared_max_age parameter to the setMaxAge() method. Only set the s-maxage if it's larger then the max-age value. Make getMaxAge() method return s-maxage if it's defined and fallback to the max-age, or 0 if no max age is defined
…ociative imploded array.
The cache_time_shared setting defines the s-maxage cache control directive. If cache_time_shared > cache_time the s-maxage directive will be added to the response to instruct proxies to cache the response longer.
This was referenced Mar 23, 2019
ercanozkaya
approved these changes
Mar 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional additional shared_max_age parameter to the
KHttpResponse::setMaxAge()method. If the shared max age value is larger then the max age value it will be set in the cache control s-maxage directive.The
KHttpResponse::getMaxAge()method now returns thes-maxageif it's defined and falls back to themax-age, or 0 if no max age is defined.A new
cache_time_sharedconfig option has been added toKDispatcherBehaviorCacheableto allow setting thes-maxage cache control directive.