Add http_cache_time_proxy setting #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new cache_time_shared setting allows to define the s-maxage cache directive. The default cache time is set to 15min and the shared cache time is set to 2h.
johanjanssens
changed the title
johanjanssens
changed the title
ercanozkaya
reviewed
Mar 25, 2019
There was a problem hiding this comment.
@johanjanssens Just a remark: If \ComPagesDispatcherBehaviorCacheable::_beforeDispatch finds a cached file \ComPagesDispatcherBehaviorCacheable::_beforeSend is not called since beforeDispatch calls response::send directly. Is that an issue?
|
@johanjanssens Never mind. Figured it out, this is good to go. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new http_cache_time_proxy setting to allows defining the s-maxage cache directive. The default cache time is set to 15min and the shared proxy cache time is set to 2h.
See also: joomlatools/joomlatools-framework#266