parsebib--get-xref-fields: use all matching biblatex rules
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for finding this bug and providing a fix! |
andras-simonyi
deleted the
Use_all_matching_rules_for_biblatex_inheritance
branch
|
Thanks for the quick reaction, and, of course, thanks for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code in
parsebib--get-xref-fieldsfinds and applies only the first specific biblatex inheritance rule that matches the given source and target but there are cases when several rules match and have to be applied, e.g., in the case ofbook->inbookinheritance, where title field inheritance is described in the second matching default rule. This PR changes to code to collect (and apply) all matching rules instead of only the first one.