Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoking element using JQuery #3

Closed
hcbelias opened this issue Aug 12, 2015 · 4 comments
Closed

Invoking element using JQuery #3

hcbelias opened this issue Aug 12, 2015 · 4 comments

Comments

@hcbelias
Copy link
Contributor

I`m having an issue that chardinJs function is undefined. I did a small test, trying to invoke the function using the JQuery selector($(element) besides of element) and it worked.

I would like to create a pull request, can you grant me permission?

scope.$watch('helpOverlay', function (newValue, oldValue) {
if (newValue !== oldValue) {
if (noop === true) {
noop = false;
} else if (newValue === true) {
==>>> $(element).chardinJs('start');
} else if (newValue === false) {
==>>> $(element).chardinJs('stop');
}
}
});

@jordanburke
Copy link
Owner

@hcbelias thanks for the info. I'm curious under what conditions would this occur? Do you have a sample test I can see?

@MartinSeeler
Copy link

I get the same error, but was not able to fix it.

@hcbelias
Copy link
Contributor Author

this is a MEAN app(Mongo/Express/Angular/Node) and I just added the
attribute to display the overlay help.

It looks like that the element reference that we get in the function is the
very basic element from the DOM, not the document obtained from JQuery.

2015-08-19 9:28 GMT-03:00 Martin Seeler notifications@github.com:

I get the same error, but was not able to fix it.


Reply to this email directly or view it on GitHub
#3 (comment)
.

@jordanburke
Copy link
Owner

Alright, still haven't seen it but I'm not using the MEAN stack so perhaps that's it. Pardon the delay - It's been merged, and thanks for providing the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants