-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freeBSD broke between v1.11.0 and v1.13.1 #1844
Comments
Actually, I just tested
I'll see if I can figure out when this broke and what's going on here 👻 |
So
|
I was hoping the Previous command with Current command with
|
🎯 Removal of this previous code most definitely negatively impacts freeBSD packages!... 💥 ab4eb18#diff-3cef554cb7a0554641ae67e83e6adfbe20bdfb8dcd7abe182e3f757649e9e481L94
|
@claytonjwong, nice work on the investigation! In #1796, I had to change how freebsd packages are built, and I think we can make it better. The change removed a dependency on the ruby I believe we can fix this by restoring some of the old behavior:
I may not have time this week to work on it as I have family in town. |
For clarity, I had hoped my change still generated correct freebsd packages, but as you report, it does not! Oops 🤦 I even see a comment where I was unsure if this would break things:
I think we can fix this as described in my previous comment, and we can also include a test case that makes sure freebsd packages have a correct file structure (files have a |
Thanks 👍 |
Hi, did this code change make it into the
v1.13.1
release?If so, then maybe it breaks freeBSD packaging: 63fdb94
Test Performed: I performed the following 2 tests back to back within freeBSD 12 on a vagrant instance on my localhost mac:
v1.13.1
to show incorrect package manifest, ie. each file is missing a/
prefix 😵v1.11.0
on the same exact files to show correct package manifest, ie. each file has a/
prefix 😊Full Test Input/Output:
The text was updated successfully, but these errors were encountered: