Fix OSX Python tests #1320
Merged
Fix OSX Python tests #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robyoung
force-pushed
the
fix-osx-python-tests
branch
3 times, most recently
from
9e16d75
to
2cc873b
Compare
The test was failing because the calculated staging path is incorrect with brew. If done in a virtualenv it is correct.
robyoung
force-pushed
the
fix-osx-python-tests
branch
from
2cc873b
to
72d0bf8
Compare
|
Finally, got the tests passing 😌 |
|
Is there anything I can do to this PR to help it get accepted? |
|
There are only so many hours in the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was failing because the calculated staging path is incorrect
with brew. If done in a virtualenv it is correct.