New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX Python tests #1320

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
2 participants
@robyoung
Contributor

robyoung commented Apr 3, 2017

The test was failing because the calculated staging path is incorrect
with brew. If done in a virtualenv it is correct.

@robyoung robyoung force-pushed the robyoung:fix-osx-python-tests branch 3 times, most recently from 9e16d75 to 2cc873b Apr 4, 2017

Fix OSX Python tests
The test was failing because the calculated staging path is incorrect
with brew. If done in a virtualenv it is correct.

@robyoung robyoung force-pushed the robyoung:fix-osx-python-tests branch from 2cc873b to 72d0bf8 Apr 4, 2017

@robyoung

This comment has been minimized.

Contributor

robyoung commented Apr 4, 2017

Finally, got the tests passing 😌

@robyoung

This comment has been minimized.

Contributor

robyoung commented Apr 21, 2017

Is there anything I can do to this PR to help it get accepted?

@jordansissel

This comment has been minimized.

Owner

jordansissel commented Apr 21, 2017

There are only so many hours in the day.

@jordansissel jordansissel merged commit 6f6e59e into jordansissel:master Apr 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment