Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the build/installation steps out of the input method for future source-based package support #2024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NicholasBHubbard
Copy link
Contributor

@NicholasBHubbard NicholasBHubbard commented Aug 30, 2023

description of this PR provided here: #1972 (comment)

@NicholasBHubbard
Copy link
Contributor Author

NicholasBHubbard commented Aug 30, 2023

not surprised that CI tests fail considering I broke all but the cpan and gem input types.

@NicholasBHubbard NicholasBHubbard changed the title separate installation logic out of input methods for gem and cpan Extract the build/installation steps out of the input method for future source-based package support Aug 30, 2023
@jordansissel
Copy link
Owner

I’m away from my workstation at the moment and will try to get this evaluated when I can in a week or two :)

@jordansissel
Copy link
Owner

This looks like a great start :)

I have some ideas and I'll shoot you a PR for them soon -- notably, changing the shell code from a multiline string to be an array of commands. I"ll also see about moving this a bit forward towards getting the test suite to pass again.

@NicholasBHubbard
Copy link
Contributor Author

I look forward to it!

@NicholasBHubbard
Copy link
Contributor Author

Hey @jordansissel, wondering if you ever got a chance to look at this more in depth. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants