-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty directories only if they match exclude pattern. #323
Conversation
spec fails though
|
Looks like an internal check, working on fixing so it passes the spec. |
I shouldn't be deleting if File.fnmatch(pattern, d) or File.dirname(file_staging_path) == "#{d}"
#delete dir But again breaks the spec as user wanted to delete |
Spec can be changed. I'm most interested in fpm behaving in "the most obvious manner by default" How about writing up the spec changes as well? |
Thanks, I'll work on the code/spec. |
* Use only File.fnmatch on paths/patterns.
The changes are now complete.
|
Remove empty directories only if they match exclude pattern.
Remove empty directories only if they match exclude pattern.
Remove empty directories only if they match exclude pattern.
Remove empty directories only if they match exclude pattern.
Remove empty directories only if they match exclude pattern.
Current exclude logic even removes the directories left empty after "exclude match" but which
don't match the exclude pattern.
This for example makes empty directories maintained under subversion
to be excluded (via
--exclude '**.svn*'
) even though intention is to include them.