Update dependency on addressable #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logstash ships with addressable 2.3.x, the constraints set on ruby-ftw 0.0.46 make it non installable on LS. And logstash-output-websocket 3.0.3 requires FTW 0.0.46, this version of the websocket output is the first version to have the documentation changes.
|
@jordansissel this fixes the issue with the documentation generator and the websocket. |
This was referenced Mar 3, 2019
|
@ph, was there any reason for updating the addressable dependency to |
|
I don’t remember exactly why we did pin it to a specific version after
looking at the change I would be ok to relax it. IIRC at that time we did
have older plugins not playing nice with addressable at all. I wish we
could isolate plugins with their dependency in a controlled way. Cc @jsvd
…On Sun, Mar 3, 2019 at 3:23 PM Magnus Bäck ***@***.***> wrote:
@ph <https://github.com/ph>, was there any reason for updating the
addressable dependency to ~> 2.3.8, ruling out 2.4 or later? With
Logstash 7 we're back to the exact same problem that you addressed with
this PR (see logstash-plugins/logstash-input-websocket#19
<logstash-plugins/logstash-input-websocket#19>)
since other parts of Logstash require addressable 2.4. Judging by addressable's
README file
<https://github.com/sporkmonger/addressable/blob/master/README.md> the
maintainer(s) appear to be pretty serious about semantic versioning and
explicitly recommend a dependency spec like ~> 2.3.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#38 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAACgFRED6IW7DQ5jJbY_ziYPzsL5rG9ks5vTC8mgaJpZM4PRqoG>
.
|
This was referenced Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logstash ships with addressable 2.3.x, the constraints set on ruby-ftw
0.0.46 make it non installable on LS.
And logstash-output-websocket 3.0.3 requires FTW 0.0.46, this version of
the websocket output is the first version to have the documentation
changes.