Update gem versions and deprecate non-keyword args

Gemfile

@@ -35,7 +35,7 @@ group :development do
 end
 
 group :test do
-  gem 'rspec-rails', '~>3.5.2'
+  gem 'rspec-rails'
   gem 'factory_girl_rails'
   gem 'ffaker'
   gem 'codeclimate-test-reporter', require: nil

Gemfile.lock

@@ -1,49 +1,49 @@
 GEM
   remote: https://rubygems.org/
   specs:
-    actioncable (5.0.2)
-      actionpack (= 5.0.2)
-      nio4r (>= 1.2, < 3.0)
+    actioncable (5.1.1)
+      actionpack (= 5.1.1)
+      nio4r (~> 2.0)
       websocket-driver (~> 0.6.1)
-    actionmailer (5.0.2)
-      actionpack (= 5.0.2)
-      actionview (= 5.0.2)
-      activejob (= 5.0.2)
+    actionmailer (5.1.1)
+      actionpack (= 5.1.1)
+      actionview (= 5.1.1)
+      activejob (= 5.1.1)
       mail (~> 2.5, >= 2.5.4)
       rails-dom-testing (~> 2.0)
-    actionpack (5.0.2)
-      actionview (= 5.0.2)
-      activesupport (= 5.0.2)
+    actionpack (5.1.1)
+      actionview (= 5.1.1)
+      activesupport (= 5.1.1)
       rack (~> 2.0)
       rack-test (~> 0.6.3)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.2)
-    actionview (5.0.2)
-      activesupport (= 5.0.2)
+    actionview (5.1.1)
+      activesupport (= 5.1.1)
       builder (~> 3.1)
-      erubis (~> 2.7.0)
+      erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.0, >= 1.0.3)
-    active_model_serializers (0.10.5)
+    active_model_serializers (0.10.6)
       actionpack (>= 4.1, < 6)
       activemodel (>= 4.1, < 6)
       case_transform (>= 0.2)
       jsonapi-renderer (>= 0.1.1.beta1, < 0.2)
-    activejob (5.0.2)
-      activesupport (= 5.0.2)
+    activejob (5.1.1)
+      activesupport (= 5.1.1)
       globalid (>= 0.3.6)
-    activemodel (5.0.2)
-      activesupport (= 5.0.2)
-    activerecord (5.0.2)
-      activemodel (= 5.0.2)
-      activesupport (= 5.0.2)
-      arel (~> 7.0)
-    activesupport (5.0.2)
+    activemodel (5.1.1)
+      activesupport (= 5.1.1)
+    activerecord (5.1.1)
+      activemodel (= 5.1.1)
+      activesupport (= 5.1.1)
+      arel (~> 8.0)
+    activesupport (5.1.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    arel (7.1.4)
+    arel (8.0.0)
     bcrypt (3.1.11)
     builder (3.2.3)
     byebug (9.0.6)
@@ -54,89 +54,89 @@ GEM
     concurrent-ruby (1.0.5)
     diff-lcs (1.3)
     docile (1.1.5)
-    erubis (2.7.0)
+    erubi (1.6.0)
     factory_girl (4.8.0)
       activesupport (>= 3.0.0)
     factory_girl_rails (4.8.0)
       factory_girl (~> 4.8.0)
       railties (>= 3.0.0)
     ffaker (2.5.0)
-    globalid (0.3.7)
-      activesupport (>= 4.1.0)
+    globalid (0.4.0)
+      activesupport (>= 4.2.0)
     i18n (0.8.1)
-    json (2.0.3)
+    json (2.1.0)
     jsonapi-renderer (0.1.2)
     loofah (2.0.3)
       nokogiri (>= 1.5.9)
-    mail (2.6.4)
+    mail (2.6.5)
       mime-types (>= 1.16, < 4)
     method_source (0.8.2)
     mime-types (3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2016.0521)
     mini_portile2 (2.1.0)
-    minitest (5.10.1)
+    minitest (5.10.2)
     nio4r (2.0.0)
-    nokogiri (1.7.1)
+    nokogiri (1.7.2)
       mini_portile2 (~> 2.1.0)
     pg (0.20.0)
     puma (3.8.2)
-    rack (2.0.1)
+    rack (2.0.3)
     rack-test (0.6.3)
       rack (>= 1.0)
-    rails (5.0.2)
-      actioncable (= 5.0.2)
-      actionmailer (= 5.0.2)
-      actionpack (= 5.0.2)
-      actionview (= 5.0.2)
-      activejob (= 5.0.2)
-      activemodel (= 5.0.2)
-      activerecord (= 5.0.2)
-      activesupport (= 5.0.2)
+    rails (5.1.1)
+      actioncable (= 5.1.1)
+      actionmailer (= 5.1.1)
+      actionpack (= 5.1.1)
+      actionview (= 5.1.1)
+      activejob (= 5.1.1)
+      activemodel (= 5.1.1)
+      activerecord (= 5.1.1)
+      activesupport (= 5.1.1)
       bundler (>= 1.3.0, < 2.0)
-      railties (= 5.0.2)
+      railties (= 5.1.1)
       sprockets-rails (>= 2.0.0)
-    rails-controller-testing (1.0.1)
-      actionpack (~> 5.x)
-      actionview (~> 5.x)
+    rails-controller-testing (1.0.2)
+      actionpack (~> 5.x, >= 5.0.1)
+      actionview (~> 5.x, >= 5.0.1)
       activesupport (~> 5.x)
-    rails-dom-testing (2.0.2)
-      activesupport (>= 4.2.0, < 6.0)
-      nokogiri (~> 1.6)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
     rails-html-sanitizer (1.0.3)
       loofah (~> 2.0)
-    rails-i18n (5.0.3)
+    rails-i18n (5.0.4)
       i18n (~> 0.7)
       railties (~> 5.0)
-    railties (5.0.2)
-      actionpack (= 5.0.2)
-      activesupport (= 5.0.2)
+    railties (5.1.1)
+      actionpack (= 5.1.1)
+      activesupport (= 5.1.1)
       method_source
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (12.0.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rspec-core (3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-expectations (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.6.0)
+    rspec-mocks (3.6.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-rails (3.5.2)
+      rspec-support (~> 3.6.0)
+    rspec-rails (3.6.0)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       railties (>= 3.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
+      rspec-core (~> 3.6.0)
+      rspec-expectations (~> 3.6.0)
+      rspec-mocks (~> 3.6.0)
+      rspec-support (~> 3.6.0)
+    rspec-support (3.6.0)
     simplecov (0.13.0)
       docile (~> 1.1.0)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
+    simplecov-html (0.10.1)
     spring (2.0.1)
       activesupport (>= 4.2)
     sprockets (3.7.1)
@@ -169,7 +169,7 @@ DEPENDENCIES
   rails
   rails-controller-testing
   rails-i18n
-  rspec-rails (~> 3.5.2)
+  rspec-rails
   spring
   tzinfo-data
 

spec/controllers/api/v1/concerns/authenticator_spec.rb

@@ -16,14 +16,14 @@ def fake_current_user
       end
 
       context 'when correctly authenticated' do
-        before { signed_get :fake_current_user, nil }
+        before { signed_get :fake_current_user, params: {} }
 
         it { expect(json_response['email']).to_not be_nil }
         it { expect(response.status).to eq 200 }
       end
 
       context 'when not authenticated' do
-        before { get :fake_current_user, nil }
+        before { get :fake_current_user, params: {} }
 
         it { expect(response.status).to eq 401 }
       end

spec/controllers/api/v1/concerns/error_handler_spec.rb

@@ -14,7 +14,7 @@ def fake_not_found
       end
 
       context 'when record not found triggered' do
-        before { signed_get :fake_not_found, nil }
+        before { signed_get :fake_not_found, params: {} }
 
         it 'renders error' do
           expect(json_response['error']['message']).to eq I18n.t(

spec/controllers/api/v1/concerns/internationalizator_spec.rb

@@ -14,31 +14,31 @@ def fake_not_found
       end
 
       it 'return english message when no locale' do
-        signed_get :fake_not_found, nil
+        signed_get :fake_not_found, params: {}
         expect(json_response['error']['message']).to eq I18n.t(
           'errors.messages.not_found', locale: I18n.default_locale)
         expect(json_response['error']['status']).to eq 404
       end
 
       it 'return english message when en locale' do
         request.env['HTTP_ACCEPT_LANGUAGE'] = 'en'
-        signed_get :fake_not_found, nil
+        signed_get :fake_not_found, params: {}
         expect(json_response['error']['message']).to eq I18n.t(
           'errors.messages.not_found', locale: :en)
         expect(json_response['error']['status']).to eq 404
       end
 
       it 'return spanish message when es locale' do
         request.env['HTTP_ACCEPT_LANGUAGE'] = 'es'
-        signed_get :fake_not_found, nil
+        signed_get :fake_not_found, params: {}
         expect(json_response['error']['message']).to eq I18n.t(
           'errors.messages.not_found', locale: :es)
         expect(json_response['error']['status']).to eq 404
       end
 
       it 'return english message when unknown locale' do
         request.env['HTTP_ACCEPT_LANGUAGE'] = 'wk'
-        signed_get :fake_not_found, nil
+        signed_get :fake_not_found, params: {}
         expect(json_response['error']['message']).to eq I18n.t(
           'errors.messages.not_found', locale: I18n.default_locale)
         expect(json_response['error']['status']).to eq 404

spec/controllers/api/v1/concerns/version_expiration_handler_spec.rb

@@ -15,15 +15,15 @@ def fake_method
       after(:each) { ENV['LAST_EXPIRED_VERSION'] = nil }
 
       context 'when no expiration date' do
-        before { signed_get :fake_method, nil }
+        before { signed_get :fake_method, params: {} }
 
         it { expect(response.status).to eq 200 }
       end
 
       context 'when expired is less' do
         before do
           ENV['LAST_EXPIRED_VERSION'] = '0'
-          signed_get :fake_method, nil
+          signed_get :fake_method, params: {}
         end
 
         it { expect(response.status).to eq 200 }
@@ -32,7 +32,7 @@ def fake_method
       context 'when version is equal or greater' do
         before do
           ENV['LAST_EXPIRED_VERSION'] = '1'
-          signed_get :fake_method, nil
+          signed_get :fake_method, params: {}
         end
 
         it 'returns expired message' do

spec/controllers/api/v1/notes_controller_spec.rb

@@ -53,7 +53,7 @@
   describe 'GET /notes #index' do
     it 'returns some notes' do
       create_list(:note, 3, user: user)
-      signed_get :index, nil
+      signed_get :index, params: {}
       expect(json_response.count).to eq 3
     end
 

spec/controllers/api/v1/sessions_controller_spec.rb

@@ -66,7 +66,7 @@
 
   describe 'DELETE /users/logout #destroy' do
     context 'when logout correctly' do
-      before(:each) { signed_delete :destroy, nil }
+      before(:each) { signed_delete :destroy, params: {} }
 
       it 'cannot be found anymore' do
         expect do

spec/controllers/api/v1/versions_controller_spec.rb

@@ -22,7 +22,7 @@
       before(:each) do
         ENV['LAST_EXPIRED_VERSION'] = '0'
         ENV['LAST_WARNED_VERSION'] = '0'
-        signed_get :state, nil
+        signed_get :state, params: {}
       end
 
       it 'returns expiration_date' do
@@ -36,7 +36,7 @@
       before(:each) do
         ENV['LAST_EXPIRED_VERSION'] = '0'
         ENV['LAST_WARNED_VERSION'] = '1'
-        signed_get :state, nil
+        signed_get :state, params: {}
       end
 
       it 'returns expiration_date' do
@@ -50,7 +50,7 @@
       before(:each) do
         ENV['LAST_EXPIRED_VERSION'] = '2'
         ENV['LAST_WARNED_VERSION'] = '3'
-        signed_get :state, nil
+        signed_get :state, params: {}
       end
 
       it 'returns expiration_date' do