-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails on env vars with quotes #14
Comments
Definitely a bug, thank you for reporting. I think we could solve this using Care you try echo "set --global --export $name "(string escape -- $value) and let me know if it works for you? |
That seems to work and it's a lot cleaner too! Thank you :) |
Huh, actually it didn't fix the problem with |
I'll just give you the complete contents of Indended contents:
Log:
|
Does it work as expected with the fix you suggested before? |
Yes |
Although variables with
|
@cdfa Anything? |
Apologies for the slow response. Work has been very busy. I did experiment a little and the version with |
Thank you, @cdfa! Please update to the latest version and try again to make sure everything is fine on your side. 👍 |
So I must have messed something up with testing, because it was broken again after the last update. The issue seems to be |
Hi! First of all, I would like to thank you for this nice tool. I ran into an issue today when using it in a nix shell. This shell sets a variable
$shellHook
which has quotes (specifically"
) in it, which results inreplay
printing some part of the value of$shellHook
.I didn't manage to reproduce the printing, but there is definitely something wrong with quotes handling:
Quotes around
hi
are missing. I played around a little myself and this seems to fix the issue:I would make a PR, but I don't know enough about how
replay
works to know if there are problems with this or other changes are needed.The text was updated successfully, but these errors were encountered: