Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Removed O(N) clone in writing CSV #1128

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Removed O(N) clone in writing CSV #1128

merged 1 commit into from
Jun 29, 2022

Conversation

jorgecarleitao
Copy link
Owner

This is only applicable to the serialize function.

@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1128 (1b785ff) into main (81ab424) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1128      +/-   ##
==========================================
+ Coverage   83.37%   83.48%   +0.10%     
==========================================
  Files         367      367              
  Lines       35574    35573       -1     
==========================================
+ Hits        29661    29697      +36     
+ Misses       5913     5876      -37     
Impacted Files Coverage Δ
src/io/csv/write/mod.rs 100.00% <100.00%> (+34.93%) ⬆️
src/io/ipc/read/schema.rs 94.88% <0.00%> (+0.31%) ⬆️
src/bitmap/immutable.rs 81.48% <0.00%> (+0.61%) ⬆️
src/io/ipc/read/reader.rs 96.75% <0.00%> (+0.72%) ⬆️
src/array/utf8/mod.rs 86.58% <0.00%> (+0.95%) ⬆️
src/bitmap/utils/slice_iterator.rs 98.78% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81ab424...1b785ff. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 9c6b74a into main Jun 29, 2022
@jorgecarleitao jorgecarleitao deleted the faster_csv branch June 29, 2022 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant