Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed wrong package name in examples #1133

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented Jul 1, 2022

Cargo with the lastest nightly will report:

warning: skipping duplicate package `parquet_write_parallel` found at `/home/xuanwo/.cargo/git/checkouts/arrow2-6249446b5f8db6f7/6608071/examples/parquet_write_parallel`

This PR fixes it.

Signed-off-by: Xuanwo github@xuanwo.io

Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

Merging #1133 (bbeabec) into main (c52b3e7) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1133      +/-   ##
==========================================
- Coverage   83.47%   83.46%   -0.02%     
==========================================
  Files         367      367              
  Lines       35578    35578              
==========================================
- Hits        29698    29694       -4     
- Misses       5880     5884       +4     
Impacted Files Coverage Δ
src/array/binary/mod.rs 88.88% <0.00%> (-1.24%) ⬇️
src/io/ipc/read/stream_async.rs 76.69% <0.00%> (-0.76%) ⬇️
src/io/ipc/read/schema.rs 94.56% <0.00%> (-0.32%) ⬇️
src/io/ipc/read/reader.rs 96.02% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c52b3e7...bbeabec. Read the comment docs.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jul 1, 2022

Clippy seems wrong in CI, should I fix this PR or start a new one?

@jorgecarleitao
Copy link
Owner

Thank you for this PR 🙇 yeah, 1.62 landed with new clippy warnings. As you prefer - if you can that would be awesome, otherwise we merge it - main is broken anyway with the new clippy.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jul 1, 2022

Thank you for this PR bow yeah, 1.62 landed with new clippy warnings. As you prefer - if you can that would be awesome, otherwise we merge it - main is broken anyway with the new clippy.

Let's start a new PR to address clippy warnings: #1134

@jorgecarleitao jorgecarleitao changed the title Fix duplicate package in examples Fixed wrong package name in examples Jul 1, 2022
@jorgecarleitao jorgecarleitao merged commit de29b33 into jorgecarleitao:main Jul 1, 2022
@jorgecarleitao jorgecarleitao added the documentation Improvements or additions to documentation label Jul 1, 2022
@Xuanwo Xuanwo deleted the fix-example branch July 1, 2022 11:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants