Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed failing to accept dictionary full of nulls #1312

Merged
merged 1 commit into from Dec 6, 2022

Conversation

ritchie46
Copy link
Collaborator

This fixes pola-rs/polars#5655

@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Base: 83.14% // Head: 83.15% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (53f265d) compared to base (6d2eccd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   83.14%   83.15%           
=======================================
  Files         369      369           
  Lines       40245    40247    +2     
=======================================
+ Hits        33461    33466    +5     
+ Misses       6784     6781    -3     
Impacted Files Coverage Δ
src/array/dictionary/mod.rs 91.76% <100.00%> (+0.09%) ⬆️
src/array/utf8/mod.rs 85.67% <0.00%> (+0.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Dec 2, 2022
@jorgecarleitao jorgecarleitao changed the title fix dictionary creation full of nulls Fixed failing to accept dictionary full of nulls Dec 6, 2022
@jorgecarleitao jorgecarleitao merged commit 7f4a289 into jorgecarleitao:main Dec 6, 2022
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Dec 6, 2022
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Dec 12, 2022
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Dec 23, 2022
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't read empty categorical column inside a parquet file
2 participants