This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Improved performance of check_indexes #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
force-pushed
the
auto_vec
branch
2 times, most recently
from
c8636ee
to
3aa86b9
Compare
Codecov ReportBase: 83.13% // Head: 83.12% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1313 +/- ##
==========================================
- Coverage 83.13% 83.12% -0.01%
==========================================
Files 370 370
Lines 40123 40158 +35
==========================================
+ Hits 33357 33383 +26
- Misses 6766 6775 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jorgecarleitao
changed the title
|
Thanks a lot, @ritchie46 ! 🙇 |
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues on the fix in #1312 to prevent conflicts.
Our generic
check_indexesdid a check onusizeconversion which can be elided depending on the key type. This PR does the check on the type instead of on the value.By doing this we can auto-vectorize check indexes and improve the performance when reading indexes from IO.