Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

improve utf8 init validity #530

Merged
merged 1 commit into from Oct 14, 2021
Merged

Conversation

ritchie46
Copy link
Collaborator

The utf8 version did still create an initial validity bitmap from a chained iterator instead of the more performance extend_constant. This PR changes that so that it aligns with the other arrays.

I also allocate the initial size of MutableBitmap to the capacity of the data array. If a user has intialized the structs with_capacity this information is already known.

@ritchie46 ritchie46 added the enhancement An improvement to an existing feature label Oct 14, 2021
@ritchie46 ritchie46 force-pushed the feat_init branch 2 times, most recently from d7746f8 to 04c5c4f Compare October 14, 2021 18:10
@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #530 (8a8cde6) into main (2e55314) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   80.20%   80.20%   -0.01%     
==========================================
  Files         381      381              
  Lines       23730    23730              
==========================================
- Hits        19033    19032       -1     
- Misses       4697     4698       +1     
Impacted Files Coverage Δ
src/array/boolean/mutable.rs 82.68% <100.00%> (ø)
src/array/list/mutable.rs 66.33% <100.00%> (ø)
src/array/primitive/mutable.rs 83.79% <100.00%> (ø)
src/array/utf8/mutable.rs 85.25% <100.00%> (ø)
src/io/avro/read/schema.rs 54.76% <0.00%> (-1.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e55314...8a8cde6. Read the comment docs.

@houqp
Copy link
Collaborator

houqp commented Oct 14, 2021

The integration test is failing probably due to new unrelated changes in upstream arrow repo.

@jorgecarleitao jorgecarleitao merged commit 0b37568 into jorgecarleitao:main Oct 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants