Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

improve utf8 init validity #530

Merged
merged 1 commit into from Oct 14, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/array/boolean/mutable.rs
Expand Up @@ -170,7 +170,7 @@ impl MutableBooleanArray {
}

fn init_validity(&mut self) {
let mut validity = MutableBitmap::new();
let mut validity = MutableBitmap::with_capacity(self.values.capacity());
jorgecarleitao marked this conversation as resolved.
Show resolved Hide resolved
validity.extend_constant(self.len(), true);
validity.set(self.len() - 1, false);
self.validity = Some(validity)
Expand Down
2 changes: 1 addition & 1 deletion src/array/list/mutable.rs
Expand Up @@ -177,7 +177,7 @@ impl<O: Offset, M: MutableArray> MutableListArray<O, M> {
fn init_validity(&mut self) {
let len = self.offsets.len() - 1;

let mut validity = MutableBitmap::new();
let mut validity = MutableBitmap::with_capacity(self.offsets.capacity());
validity.extend_constant(len, true);
validity.set(len - 1, false);
self.validity = Some(validity)
Expand Down
2 changes: 1 addition & 1 deletion src/array/primitive/mutable.rs
Expand Up @@ -217,7 +217,7 @@ impl<T: NativeType> MutablePrimitiveArray<T> {
}

fn init_validity(&mut self) {
let mut validity = MutableBitmap::new();
let mut validity = MutableBitmap::with_capacity(self.values.capacity());
validity.extend_constant(self.len(), true);
validity.set(self.len() - 1, false);
self.validity = Some(validity)
Expand Down
9 changes: 4 additions & 5 deletions src/array/utf8/mutable.rs
Expand Up @@ -152,11 +152,10 @@ impl<O: Offset> MutableUtf8Array<O> {
}

fn init_validity(&mut self) {
self.validity = Some(MutableBitmap::from_trusted_len_iter(
std::iter::repeat(true)
.take(self.len() - 1)
.chain(std::iter::once(false)),
))
let mut validity = MutableBitmap::with_capacity(self.offsets.capacity());
validity.extend_constant(self.len(), true);
validity.set(self.len() - 1, false);
self.validity = Some(validity);
}

/// Converts itself into an [`Array`].
Expand Down