Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added any and all kernel #739

Merged
merged 2 commits into from Jan 8, 2022
Merged

Conversation

ritchie46
Copy link
Collaborator

First part for #738. I'll continue with the all after first review.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #739 (8fdbbf4) into main (299df30) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #739      +/-   ##
==========================================
+ Coverage   70.78%   70.81%   +0.03%     
==========================================
  Files         313      313              
  Lines       16899    16911      +12     
==========================================
+ Hits        11962    11976      +14     
+ Misses       4937     4935       -2     
Impacted Files Coverage Δ
src/compute/boolean.rs 90.90% <75.00%> (-4.44%) ⬇️
src/compute/arithmetics/time.rs 26.60% <0.00%> (+0.91%) ⬆️
src/array/mod.rs 69.29% <0.00%> (+1.75%) ⬆️
src/array/boolean/iterator.rs 71.42% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299df30...8fdbbf4. Read the comment docs.

@ritchie46
Copy link
Collaborator Author

Used the cached null counts and added the all kernel. Good to go on my part.

@jorgecarleitao jorgecarleitao merged commit 1c78fe9 into jorgecarleitao:main Jan 8, 2022
@jorgecarleitao jorgecarleitao added the feature A new feature label Jan 8, 2022
@jorgecarleitao jorgecarleitao changed the title implement any kernel Added `any kernel Jan 8, 2022
@jorgecarleitao jorgecarleitao changed the title Added `any kernel Added any and all kernel Jan 8, 2022
@jorgecarleitao
Copy link
Owner

Thanks a lot, @ritchie46 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants